FS#76684 - [firefox] screensharing patch breaks screensharing

Attached to Project: Arch Linux
Opened by Andrew Martens (mrtilo) - Sunday, 27 November 2022, 21:48 GMT
Last edited by Toolybird (Toolybird) - Sunday, 03 September 2023, 08:37 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jan Alexander Steffens (heftig)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Current version of firefox share a black screen.

I used the downgrade utility to downgrade firefox.

Firefox 106.0.1 can share screen correctly.

Firefox 106.0.2 shares a completely black screen.

I went to Mozilla Firefox mercurial repo, but couldn't find commits about screencasting from 106.0.1 to 106.0.2.

Then I see that Arch has added a patch that has to do with screencasting in 106.0.2, which was apparently not there in 106.0.1.

See [here](https://github.com/archlinux/svntogit-packages/commit/7c5cd818f2574660d6f48442382983f9fabf0d62).

Could this be it?

Detailed information about my configuration can be found in the [xdg-desktop-portal-wlr bug report](https://github.com/emersion/xdg-desktop-portal-wlr/issues/250).

Additional info:
* package version(s) 106.0.2
* config and/or log files etc.: see above
* link to upstream bug report, if any: see above

Steps to reproduce:

Go [here](https://mozilla.github.io/webrtc-landing/gum_test.html) and try to share the screen.
This task depends upon

Closed by  Toolybird (Toolybird)
Sunday, 03 September 2023, 08:37 GMT
Reason for closing:  Fixed
Additional comments about closing:  patch gone as of firefox 111.0-1
Comment by Toolybird (Toolybird) - Monday, 28 November 2022, 01:53 GMT
In the linked upstream report, you say chrome is also affected. It doesn't make any sense that a patch to firefox could also affect chrome. Patch was added because of  FS#76231 . Does it work if you compile firefox without the patch?
Comment by Andrew Martens (mrtilo) - Monday, 28 November 2022, 15:40 GMT
I tried to remove the "patch" command and the patch file from PKGBUILD but I can't build it.

❯ makepkg --cleanbuild
==> Making package: firefox 107.0-1 (Mon 28 Nov 2022 04:38:45 PM CET)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
-> Downloading firefox-107.0.source.tar.xz...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 487M 100 487M 0 0 49.2M 0 0:00:09 0:00:09 --:--:-- 49.5M
-> Downloading firefox-107.0.source.tar.xz.asc...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 833 100 833 0 0 10763 0 --:--:-- --:--:-- --:--:-- 10960
-> Found firefox.desktop
-> Found identity-icons-brand.svg
==> ERROR: Integrity checks (sha256) differ in size from the source array.
Comment by Toolybird (Toolybird) - Tuesday, 29 November 2022, 21:48 GMT
Um, you seem to be not familiar with compiling packages in Arch. Honestly, if you're going to run Arch as a daily driver and report bugs against the distro, you *must* IMHO become proficient in this area [1]. Official Arch packages are built in a clean chroot [2]. The only PKGBUILD edit you need is to "rem" out this single line:

patch -Np1 -i ../0001-libwebrtc-screen-cast-sync.patch

[1] https://wiki.archlinux.org/title/Arch_Build_System
[2] https://wiki.archlinux.org/title/DeveloperWiki:Building_in_a_clean_chroot
Comment by Andrew Martens (mrtilo) - Sunday, 11 December 2022, 04:47 GMT
You misread the linked upstream issue. It's resolved WITH THE APP IMAGE OF FIREFOX, which doesn't contain the patch, not with the patched version
Comment by Toolybird (Toolybird) - Sunday, 11 December 2022, 04:48 GMT
Well, it would be great if you could do what was requested. Did you manage to build it without the patch?
Comment by Andrew Martens (mrtilo) - Sunday, 11 December 2022, 04:56 GMT
I did not, I'll try in the following days.

I think it will be an academic curiosity, since version 109 of Firefox, which will be out in January, is built against latest version of libwebrtc and that fixes the problem with GNOME/KDE DE that this patch addresses.

So this patch should be gone anyway with version 109.
Comment by Toolybird (Toolybird) - Sunday, 11 December 2022, 05:03 GMT
Ok, will defer to PM's better judgement for if/when action is required.
Comment by Andrew Martens (mrtilo) - Monday, 23 January 2023, 11:09 GMT
I wrote to Jan Grulich.

He told me that the patch is still needed with FF 109, but can be dropped in the future with FF 110 or 111 as they already fixed it on their side apparently. You will find out once it doesn't apply.


Loading...