FS#76623 - [uboot-tools] Miscellaneous improvements

Attached to Project: Community Packages
Opened by Sean Anderson (Forty-Bot) - Saturday, 19 November 2022, 02:45 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:04 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Jelle van der Waa (jelly)
Filipe Laíns (FFY00)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The following patches (attached) add some documentation/tools which live in the U-Boot repository, but which were not packaged.

Sean Anderson (3):
Package dumpimage man page
Package patman
Change pkgbase to u-boot

trunk/PKGBUILD | 33 ++++++++++++++++++++++++---------
1 file changed, 24 insertions(+), 9 deletions(-)
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:04 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/uboot-tools/issues/1
Comment by Jelle van der Waa (jelly) - Friday, 25 November 2022, 21:06 GMT
I'm with with the 1,2 patch, changing the pkgbase is a bit of a beautification. Doesn't really add much.

Did you do a test build?

make: sdl2-config: No such file or directory
HOSTCC scripts/dtc/data.o
PYMOD rebuild
/bin/sh: line 1: python3: command not found

patman does not seem to useful as a separate package as checkpatch.pl is not available:

[jelle@t14s][/tmp/Dotfiles]%patman -c 1
Cleaned 1 patch
Cannot find checkpatch.pl - please put it in your ~/bin directory or use --no-check

As it really is intended to use for u-boot only, I don't think we should bother packaging this.
Comment by Sean Anderson (Forty-Bot) - Friday, 25 November 2022, 23:21 GMT
> I'm with with the 1,2 patch, changing the pkgbase is a bit of a beautification. Doesn't really add much.

That's why I left it at the end :)

> Did you do a test build?

Yes.

> /bin/sh: line 1: python3: command not found

I can't reproduce this. Can you determine what line of the PKGBUILD this is from?

> patman does not seem to useful as a separate package as checkpatch.pl is not available:

As the output says, use --no-check if the project you are working with doesn't have a checkpatch.

> As it really is intended to use for u-boot only, I don't think we should bother packaging this.

It is a general-purpose tool for patch submission. I use it for Linux and other email-based projects as well. It lives in U-Boot mostly due to historical reasons.
Comment by Jelle van der Waa (jelly) - Sunday, 27 November 2022, 09:44 GMT
> I'm with with the 1,2 patch, changing the pkgbase is a bit of a beautification. Doesn't really add much.

> That's why I left it at the end :)

:)

> /bin/sh: line 1: python3: command not found

> I can't reproduce this. Can you determine what line of the PKGBUILD this is from?

I build with extra-x86_64-build so in a clean chroot, maybe you ran makepkg? It's not a big issue.

> patman does not seem to useful as a separate package as checkpatch.pl is not available:

> As the output says, use --no-check if the project you are working with doesn't have a checkpatch.

ah TIL!

> As it really is intended to use for u-boot only, I don't think we should bother packaging this.

> It is a general-purpose tool for patch submission. I use it for Linux and other email-based projects as well. It lives in U-Boot mostly due to historical reasons.

Ah ok, I never knew it was used outside of u-boot interesting! I am suprised as almost no distro packages u-boot-tools and no one seems to package patman.

https://linux-sunxi.org/U-Boot/Tools
Comment by Sean Anderson (Forty-Bot) - Sunday, 27 November 2022, 16:30 GMT
>>> /bin/sh: line 1: python3: command not found
>> I can't reproduce this. Can you determine what line of the PKGBUILD this is from?
> I build with extra-x86_64-build so in a clean chroot, maybe you ran makepkg? It's not a big issue.

OK, looks like this was because python wasn't installed. Normally, depends are makedepends, but I guess that's not the case for split packages (maybe since it only lives in the package function). I've attached a new version of the second patch.

> Ah ok, I never knew it was used outside of u-boot interesting! I am suprised as almost no distro packages u-boot-tools and no one seems to package patman.

Well, I would like to recommend it to people, because I think it's very useful. But not everyone has a copy of U-Boot checked out. So I would like to help get it packaged in different distros. I am starting with Arch because that's what I use myself :)

Loading...