FS#76534 - [fillets-ng] fails to link against smpeg

Attached to Project: Community Packages
Opened by myself600 (myself600) - Friday, 11 November 2022, 22:45 GMT
Last edited by T.J. Townsend (blakkheim) - Sunday, 13 November 2022, 19:41 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Jaroslav Lichtblau (Dragonlord)
T.J. Townsend (blakkheim)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Following https://bugs.archlinux.org/task/76509, I'm reopening my pull request. Now I have 2 issues:

1. smpeg package have been updated to 2.0.0 which breaks fillets-ng dependency of smpeg (assuming is can be fixed to work):

checking for SMPEG_new in -lsmpeg... no
...
Checked components: X11=yes, WINDRES=no, FRIBIDI=yes, SMPEG=no
...
https://i.imgur.com/Qkkhlxo.png


2. Unpatched PKGBUILD gives me this error (I'm building on Manjaro ARM):

ScriptState.cpp: In constructor ‘ScriptState::ScriptState()’:
ScriptState.cpp:25:15: error: ‘lua_open’ was not declared in this scope; did you mean ‘lua_len’?
25 | m_state = lua_open();
| ^~~~~~~~
| lua_len
ScriptState.cpp: In member function ‘void ScriptState::prepareErrorHandler()’:
ScriptState.cpp:47:27: error: ‘LUA_GLOBALSINDEX’ was not declared in this scope
47 | lua_settable(m_state, LUA_GLOBALSINDEX);
| ^~~~~~~~~~~~~~~~
ScriptState.cpp: In member function ‘void ScriptState::insertErrorHandler(int)’:
ScriptState.cpp:57:25: error: ‘LUA_GLOBALSINDEX’ was not declared in this scope
57 | lua_rawget(m_state, LUA_GLOBALSINDEX);
| ^~~~~~~~~~~~~~~~
make[2]: *** [Makefile:359: ScriptState.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/build/fillets-ng/src/fillets-ng-1.0.1/src/gengine'
make[1]: *** [Makefile:215: all-recursive] Error 1
make[1]: Leaving directory '/build/fillets-ng/src/fillets-ng-1.0.1/src'
make: *** [Makefile:285: all-recursive] Error 1
==> ERROR: A failure occurred in build().
Aborting...
==> ERROR: Building package [fillets-ng] failed.
Cleaning up.

The output above comes from a clean chroot as requested. aarch64 can be removed from PKGBUILD as noted.
This task depends upon

Closed by  T.J. Townsend (blakkheim)
Sunday, 13 November 2022, 19:41 GMT
Reason for closing:  Works for me
Comment by Toolybird (Toolybird) - Sunday, 13 November 2022, 07:34 GMT
Regarding your 2nd point:
- we don't officially support ARM so anything ARM related is irrelevant here.
- this is not the Manjaro bug tracker. So again, irrelevant here.

Please report issues *only* against official Arch x86_64 pkgs.

Now, the first point is valid. I'm seeing the same "doesn't link against smpeg" issue.
Comment by myself600 (myself600) - Sunday, 13 November 2022, 11:32 GMT
I think it's ok to push changes upstream as long as the patches are not ARM (see the updated PKGBUILD) or distro specific. Otherwise your complains are valid (not sure why this error happens on aarch64 anyway).
   PKGBUILD (1.9 KiB)
Comment by T.J. Townsend (blakkheim) - Sunday, 13 November 2022, 13:31 GMT
Can't help with build failures on unsupported platforms and other distros.

What is the downside of fillets-ng not detecting smpeg 2.0.0? Is there loss of some functionality (on vanilla Arch Linux x86_64) as a result of this?
Comment by myself600 (myself600) - Sunday, 13 November 2022, 15:58 GMT
Build failure is the motivation behind this request, but it's about general improvements to the already existing PKGBUILD (hence why I called the task "Update package" before).

smpeg is a whole different topic. There was a separate package called smpeg2 that was deleted in the past, so it may be wise to keep the naming convention intact: https://pkgs.org/search/?q=smpeg
Comment by T.J. Townsend (blakkheim) - Sunday, 13 November 2022, 18:27 GMT
We knew fillets-ng didn't detect smpeg 2.0.0, but it was thought that no meaningful loss of functionality occured in that update. I just ran fillets from the current repos without any obvious problems.

If there's nothing else, we can close this task.
Comment by myself600 (myself600) - Sunday, 13 November 2022, 19:33 GMT
I understand. I believe the task got sidetracked from what it was intended to be. Since this is a bug tracker, where can I suggest general improvements to particular packages?
Comment by T.J. Townsend (blakkheim) - Sunday, 13 November 2022, 19:41 GMT
If it's relevant to Arch, you can open a task here with the "feature request" category or just email the maintainer directly.

Loading...