FS#76241 - [python-kubernetes] Package uses out-of-date `python-base` repo when building
Attached to Project:
Community Packages
Opened by Kevin R (rkevin) - Wednesday, 19 October 2022, 01:46 GMT
Last edited by Thore Bödecker (foxxx0) - Sunday, 27 November 2022, 10:09 GMT
Opened by Kevin R (rkevin) - Wednesday, 19 October 2022, 01:46 GMT
Last edited by Thore Bödecker (foxxx0) - Sunday, 27 November 2022, 10:09 GMT
|
Details
The current (`24.2.0-1`) PKGBUILD for `python-kubernetes`
builds from a super old commit for `python-base` (from May
2021) ([PKGBUILD](
https://github.com/archlinux/svntogit-community/blob/daaf277257332bb42c6e6b805619535f4689cb55/trunk/PKGBUILD#L6
)). The `python-base` repo got merged in `python-kubernetes`
as of Jan 2022 ([PR](
https://github.com/kubernetes-client/python/pull/1672
)), so all the things in the current PKGBUILD about having
to symlink in `python-base` is no longer necessary.
I noticed this when I wanted to use the `kubernetes.config.load_config` method added [in Jun 2021]( https://github.com/kubernetes-client/python-base/pull/221 ) but couldn't find it on my system. The latest wheel from [pypi]( https://pypi.org/project/kubernetes/24.2.0/ ) for `24.2.0` contains this function, but not in the package built by the PKGBUILD since it uses an older `python-base`. You can check `usr/lib/python3.10/site-packages/kubernetes/config/__init__.py` in the Arch package and it doesn't contain the `load_config` function, while `kubernetes/config/__init__.py` from upstream pypi contains the function. We should get rid of the part in PKGBUILD that downloads a separate `python-base` and symlinks it in, since the git submodule is now in the main repo and there's no need to download it separately. |
This task depends upon
Closed by Thore Bödecker (foxxx0)
Sunday, 27 November 2022, 10:09 GMT
Reason for closing: Fixed
Additional comments about closing: fixed as of python-kubernetes 25.3.0-1
Sunday, 27 November 2022, 10:09 GMT
Reason for closing: Fixed
Additional comments about closing: fixed as of python-kubernetes 25.3.0-1
```
6d5
< _kubernetes_base_commit=b4d3aad42dc23e7a6c0e5c032691f8dc385a786c
8c7
< pkgrel=1
---
> pkgrel=2
19,22c18,19
< source=("${_pkgbase}-${pkgver}.tar.gz::${url}/archive/v${pkgver}.tar.gz"
< "${_pkgbase}-base-${_kubernetes_base_commit}.tar.gz::https://github.com/kubernetes-client/python-base/archive/${_kubernetes_base_commit}.tar.gz")
< sha256sums=('68330be70d281f8e7193fb38ce4a51355f1c05d2e6f33d09f113a7b944491627'
< 'c76a4f51e662132da2d29cafafe6aeab1778d7e546dc7c918ec6f3e1d4943871')
---
> source=("${_pkgbase}-${pkgver}.tar.gz::${url}/archive/v${pkgver}.tar.gz")
> sha256sums=('68330be70d281f8e7193fb38ce4a51355f1c05d2e6f33d09f113a7b944491627')
28,32d24
< mv -v "python-base-${_kubernetes_base_commit}" "${_pkgbase}-base-${_kubernetes_base_commit}"
<
< # their "base" has been split out to a git submodule, so include it via symlink
< rm -vrf "${_pkgbase}-${pkgver}/kubernetes/base"
< ln -vsf "${srcdir}/${_pkgbase}-base-${_kubernetes_base_commit}" "${_pkgbase}-${pkgver}/kubernetes/base"
```