FS#76121 - [vi] FTBFS

Attached to Project: Arch Linux
Opened by Sebastien Duthil (duthils) - Wednesday, 05 October 2022, 22:40 GMT
Last edited by Evangelos Foutras (foutrelis) - Thursday, 06 October 2022, 01:13 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Evangelos Foutras (foutrelis)
Architecture x86_64
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: Package vi from Core cannot build with the latest `makepkg`. The build fails due to `-Werror=format-security` that was added in default `CFLAGS` a few months ago.

Additional info:
* package version: vi 1:070224-5
* This bug causes the package `vi` to fail in the [Reproducible Builds](https://tests.reproducible-builds.org/archlinux/state_core_FTBFS.html) status page.

Steps to reproduce:

* Clone package source files (PKGBUILD and co.)
* Import the PGP key included in `keys/`
* Run `makepkg`
* The build fails with:

```
ex_unix.c:182:17: error: format not a string literal and no format arguments [-Werror=format-security]
182 | printf(mesg(catgets(catd, 1, 197,
| ^~~~~~
```

Attached is a patch to add the proper format string `"%s"` in 2 `printf` calls, making the build finish successfully.
   vi-format-security.patch (0.7 KiB)
This task depends upon

Closed by  Evangelos Foutras (foutrelis)
Thursday, 06 October 2022, 01:13 GMT
Reason for closing:  Fixed
Additional comments about closing:  vi-1:070224-6 -- thanks for the patch
Comment by Sebastien Duthil (duthils) - Wednesday, 05 October 2022, 22:49 GMT
Apologies for the missing task summary, I can't edit the task to change it.

Loading...