FS#76070 - [go] fix (accidentally?) quoted glob in PKGBUILD

Attached to Project: Community Packages
Opened by env (ENV25) - Friday, 30 September 2022, 08:32 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:04 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Lukas Fleischer (lfleischer)
George Rawlinson (rawlinsong)
Morten Linderud (Foxboron)
Architecture x86_64
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

PKGBUILD has the following command, where a glob pattern is quoted:

```
build() {
...
rm -rf "$pkgdir/usr/lib/go/pkg/bootstrap" "$pkgdir/usr/lib/go/pkg/tool/*/api"
...
}
```

Additional info:
* 1.19.1
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:04 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/go/issues/1
Comment by Toolybird (Toolybird) - Monday, 03 October 2022, 04:39 GMT
Careful! If you fix it, this binary will get removed:

/usr/lib/go/pkg/tool/linux_amd64/api

I have no idea if this is intentional or not. Also, the first part of that rm statement seems redundant i.e. "$pkgdir/usr/lib/go/pkg/bootstrap".

Sidenote: I'm a fan of adding verbosity (-v) to "rm", "cp" and friends to spot this kind of issue.
Comment by env (ENV25) - Monday, 03 October 2022, 08:57 GMT
>Careful! If you fix it, this binary will get removed:
>
>/usr/lib/go/pkg/tool/linux_amd64/api

I don't think the tool is meant to be used:

```
% go tool api
go: no such tool "api"
```

https://github.com/golang/go/issues/29836
https://github.com/golang/go/issues/13030

Loading...