FS#75972 - [rz-cutter] unused dependency 'qt5-webengine'

Attached to Project: Community Packages
Opened by bill-auger (bill-auger) - Thursday, 22 September 2022, 07:02 GMT
Last edited by Antonio Rojas (arojas) - Saturday, 02 September 2023, 09:00 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Levente Polyak (anthraxx)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

webengine does not appear to be necessary, or even used for this build - according to the upstream, webengine support was disabled by default four years ago

https://github.com/rizinorg/cutter/pull/728/files

webengine was used for the jupyter integration feature - in order to enable it, required passing an explicit config var

-DCUTTER_ENABLE_JUPYTER=ON
-DCUTTER_ENABLE_QTWEBENGINE=ON

however, if one tries that now, the related config vars are ignored

| CMake Warning:
| Manually-specified variables were not used by the project:
| CUTTER_ENABLE_JUPYTER
| CUTTER_ENABLE_QTWEBENGINE

so, it appears that the jupyter integration feature was removed; and webengine no longer serves a purpose

also, the current PKGBUILD downloads the source from VCS, though the package is not named ending -git, yet the upstream publishes versioned source-balls regularly

the translations are published only as VCS sources; but still the 'git' makedepends is unnecessary - the translations change infrequently, compared to the main program; so the git 'master' source-ball is a perfectly reasonable source

i compiled using this modified PKGBUILD, and it runs with no problems - please consider adopting these changes
This task depends upon

Closed by  Antonio Rojas (arojas)
Saturday, 02 September 2023, 09:00 GMT
Reason for closing:  Fixed
Additional comments about closing:  rz-cutter 2.3.1-1

Loading...