FS#75814 - [firefox-adblock-plus] [firefox-noscript] fix checkdepends list

Attached to Project: Community Packages
Opened by T.J. Townsend (blakkheim) - Monday, 05 September 2022, 17:10 GMT
Last edited by Toolybird (Toolybird) - Tuesday, 06 September 2022, 04:06 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
The Adblock Plus and NoScript packages both incorrectly list unzip as a make dependency. The unzip lines are only in the check() stage of the PKGBUILDs, so this means it should be a checkdepends line.

But in fact unzip is not required at all. We can use bsdtar to extract the files and drop this dependency in both cases.

The attached diff fixes both of these issues.
   ff-addons.diff (1.9 KiB)
This task depends upon

Closed by  Toolybird (Toolybird)
Tuesday, 06 September 2022, 04:06 GMT
Reason for closing:  Fixed
Additional comments about closing:  Reporter says "issues have been fixed"
Comment by T.J. Townsend (blakkheim) - Monday, 05 September 2022, 20:43 GMT
  • Field changed: Percent Complete (100% → 0%)
The commit to fix this dropped unzip from makedepends but did not switch jq to checkdepends (as was done in the diff provided) -- https://lists.archlinux.org/pipermail/arch-commits/2022-September/1268364.html
Comment by Sergej Pupykin (sergej) - Monday, 05 September 2022, 21:57 GMT
sorry, I missed that

Loading...