FS#75757 - lshw: path to icon is hardcoded in desktop file.

Attached to Project: Community Packages
Opened by Matrix (Matr1x-101) - Wednesday, 31 August 2022, 07:57 GMT
Last edited by Toolybird (Toolybird) - Wednesday, 31 August 2022, 20:42 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: In the package "lshw", the path to the svg icon is hardcoded in the desktop file. This makes the desktop file incompatible with icon packs, as the icon is hardcoded. Instead of this, the icon (which is /usr/share/lshw/artwork/logo.svg) should be symlinked to /usr/share/icons/hicolor/symbolic/lshw.svg, and the icon parameter in the desktop file should be changed to "Icon=lshw"

Please note, this is not an upstream issue as the developer might have wanted the path to the icon hardcoded.

Additional info:
* package version(s): all versions are affected
* config and/or log files etc.: https://github.com/lyonel/lshw/blob/master/src/gui/integration/gtk-lshw.desktop and https://github.com/lyonel/lshw/blob/master/src/gui/artwork/logo.svg are the files in question
* link to upstream bug report, if any: none

Steps to reproduce:
1. Install lshw.
2. In /usr/share/applications, you can see that the parameter "Icon" in gtk-lshw.desktop is hardcoded.
This task depends upon

Closed by  Toolybird (Toolybird)
Wednesday, 31 August 2022, 20:42 GMT
Reason for closing:  Upstream
Additional comments about closing:  Reporter says "I realized is probably an upstream issue"
Comment by Doug Newgard (Scimmia) - Wednesday, 31 August 2022, 12:56 GMT
The fact that you linked to the upstream file, which is hardcoded, pretty much proves that it's an upstream issue. Why would you say it isn't?
Comment by Matrix (Matr1x-101) - Wednesday, 31 August 2022, 19:25 GMT
I believe that the developer wanted it this way for other linux distros that maybe dont use hicolor. Besides, many other offical Arch packages' PKGBUILDs have commands for fixing broken/buggy .desktop files.

Edit: On second thoughts you're probably right. I'll make a pull request to the upstream GitHub, and if that doesn't work, i'll maybe reopen this bug.

Loading...