Description:

If I try to complete a terraform command which includes a flag which does not exist for that command, such as `terraform apply -z` (none of apply's flags begin with z), this produces the error from the completion

string join: -z: unknown option

As well as a lot of other debug output.

The problem is caused by the line

set -lx COMP_LINE (string join ' ' (commandline -o))

Which should actually be

set -lx COMP_LINE (string join -- ' ' (commandline -o))

to ensure that flags in the command line are not interpreted as flags to `string join`.

However, another option would be to simply remove the fish completion shipped with the arch terraform package, as the arch fish package ships with its own terraform completion, and the one in the terraform package appears to just shadow the one in the fish package.

~ 19:59 $ pacman -Qi terraform | grep Version
Version : 1.2.7-1
~ 19:59 $ pacman -Qi fish | grep Version
Version : 3.5.1-1