FS#7551 - i18n list formatting

Attached to Project: Pacman
Opened by Sergej Pupykin (sergej) - Monday, 02 July 2007, 14:47 GMT
Last edited by Dan McGee (toofishes) - Thursday, 12 July 2007, 13:20 GMT
Task Type Bug Report
Category Output
Status Closed
Assigned To Aaron Griffin (phrakture)
Architecture All
Severity Low
Priority Normal
Reported Version 3.0.5
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Summary and Info:

Bad formatting in src/pacman/util.c/list_display() function.

Steps to Reproduce:

- switch to multybyte locale (for example ru_RU.UTF-8)
- pacman -Qi xorg
- see to Depends on section

Patch attached.
   list_display.patch (0.9 KiB)
This task depends upon

Closed by  Dan McGee (toofishes)
Thursday, 12 July 2007, 13:20 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed in GIT
Comment by Dan McGee (toofishes) - Monday, 09 July 2007, 20:59 GMT
Can you explain why this part is necessary?

+ if(getenv("LC_CTYPE") == NULL)
+ {
+ setlocale(LC_CTYPE, getenv("LC_ALL"));
+ }
+
Comment by Sergej Pupykin (sergej) - Tuesday, 10 July 2007, 10:00 GMT
On my system only LC_ALL variable set. For unknown reason mbstowcs function do not see to LC_ALL and works as my locale is not known.
Comment by Dan McGee (toofishes) - Wednesday, 11 July 2007, 03:30 GMT
Hmm. When I set either LANG or LC_ALL on my machine, it affects LC_CTYPE as it should. In any case, the localization code has changed a good amount from pacman 3.0.X to the current GIT version. I'm going to just use the second half of your patch for now, and maybe you could do a bit more experimentation with LANG and LC_ALL?
Comment by Sergej Pupykin (sergej) - Wednesday, 11 July 2007, 15:21 GMT
I think you may omit this part of patch. Anyway I can set LC_CTYPE env. variable.
Comment by Dan McGee (toofishes) - Wednesday, 11 July 2007, 15:35 GMT
It is in the GIT tree. I fixed it in a few other places as well. Can I close the bug?

http://projects.archlinux.org/git/?p=pacman.git;a=commitdiff;h=1646fcc5bdb71dc4d27204de88da952d95d5902c;hp=64e45a36f868ca0386393d6b6cf05ffff09b5439
Comment by Sergej Pupykin (sergej) - Thursday, 12 July 2007, 12:06 GMT
Yes, you can.

Loading...