FS#75358 - [musescore] Define CMAKE_BUILD_TYPE=Release in build

Attached to Project: Community Packages
Opened by Dessa Simpson (virtualdxs) - Sunday, 17 July 2022, 20:20 GMT
Last edited by Maxime Gauduin (Alucryd) - Tuesday, 09 August 2022, 08:05 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Maxime Gauduin (Alucryd)
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

I'm hitting some QT asserts fairly frequently (on the order of 30 times in a 2-3 hour session), which are supposed to be disabled in release builds. The official AppImage build sets CMAKE_BUILD_TYPE=Release per https://github.com/musescore/MuseScore#release-build. I rebuilt this package myself with the following change:

diff --git a/musescore/trunk/PKGBUILD b/musescore/trunk/PKGBUILD
index 08803577..3f98cc52 100644
--- a/musescore/trunk/PKGBUILD
+++ b/musescore/trunk/PKGBUILD
@@ -54,6 +54,7 @@ pkgver() {

build() {
cmake -S MuseScore -B build \
+ -DCMAKE_BUILD_TYPE=Release \
-DCMAKE_INSTALL_PREFIX=/usr \
-DCMAKE_SKIP_RPATH=ON \
-DBUILD_CRASH_REPORTER=OFF \

After adding that line and rebuilding, I've been using it for about an hour now with no crashes.

Additional info:
* package version: 3.6.2-5

I don't have any particularly reliable steps to cause the crashes.

Selected high priority because while the main functionality does work, frequent crashes are not only annoying but cause unsaved changes to be lost (and I've had a couple crashes triggered by the save operation itself).
This task depends upon

Closed by  Maxime Gauduin (Alucryd)
Tuesday, 09 August 2022, 08:05 GMT
Reason for closing:  Fixed
Additional comments about closing:  3.6.2-6
Comment by Antonio Rojas (arojas) - Sunday, 17 July 2022, 21:08 GMT
Please post the actual errors you're seeing.
Comment by Dessa Simpson (virtualdxs) - Sunday, 17 July 2022, 21:11 GMT
One example is:

/build/musescore/src/MuseScore/libmscore/measure.cpp:unknown: ASSERT: "first()" in file /build/musescore/src/MuseScore/libmscore/measure.cpp, line 1983

I've filed an upstream bug for that assert here: https://musescore.org/en/node/333304#comment-1134481

Upstream responded with "use the AppImage", which is built with CMAKE_BUILD_TYPE=Release, so I rebuilt with that and it "fixed" the crashes.
Comment by Mark Wagie (yochananmarqos) - Sunday, 17 July 2022, 21:59 GMT
@Antonio: I haven't actually looked, but maybe something like I do with downzemall in the AUR can be used?

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=downzemall#n25

Loading...