FS#75241 - [linux] linux >= v5.18.8 breaks cifs mounts for some servers

Attached to Project: Arch Linux
Opened by Ronan Pigott (Brocellous) - Monday, 04 July 2022, 20:55 GMT
Last edited by Toolybird (Toolybird) - Tuesday, 02 August 2022, 08:50 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Description:

CIFS mounts may be broken by linux >= 5.18.8, lkml report and fix here [1]. IIUC, the required fix is to revert these:

$ git rev-list v5.18.7.. -- fs/cifs
16d5d9100927673e1398ed61712d3a94d91ca868
ca83f50b43a099345e61950f74c4d9eb81c765fe

I tried to revert these myself, however seems I get linker errors in linux-stable 5.18.9 when building this module after copying my /proc/config.gz, with or without applying the reverts:

MODPOST fs/cifs/Module.symvers
ERROR: modpost: "__put_devmap_managed_page" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "kmem_cache_alloc_lru" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "__fscache_begin_write_operation" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "__fscache_use_cookie" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "kfree_skb_reason" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "__module_put_and_kthread_exit" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "__fscache_relinquish_volume" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "hugetlb_free_vmemmap_enabled_key" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "__fscache_unuse_cookie" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "__trace_trigger_soft_disabled" [fs/cifs/cifs.ko] undefined!
WARNING: modpost: suppressed 3 unresolved symbol warnings because there were too many)
make[1]: *** [scripts/Makefile.modpost:134: fs/cifs/Module.symvers] Error 1
make[1]: *** Deleting file 'fs/cifs/Module.symvers'
make: *** [Makefile:1753: modules] Error 2
MODPOST fs/cifs/Module.symvers
ERROR: modpost: "__put_devmap_managed_page" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "kmem_cache_alloc_lru" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "__fscache_begin_write_operation" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "__fscache_use_cookie" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "kfree_skb_reason" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "__module_put_and_kthread_exit" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "__fscache_relinquish_volume" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "hugetlb_free_vmemmap_enabled_key" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "__fscache_unuse_cookie" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "__trace_trigger_soft_disabled" [fs/cifs/cifs.ko] undefined!
WARNING: modpost: suppressed 3 unresolved symbol warnings because there were too many)
make[1]: *** [scripts/Makefile.modpost:134: fs/cifs/Module.symvers] Error 1
make[1]: *** Deleting file 'fs/cifs/Module.symvers'
make: *** [Makefile:1753: modules] Error 2

My system is up-to-date, with gcc version 12.1.0-2. So now I'm not sure what to do about it and reporting it here.

[1] https://lore.kernel.org/linux-cifs/20220630203207.ewmdgnzzjauofgru@cyberdelia/T/#t
This task depends upon

Closed by  Toolybird (Toolybird)
Tuesday, 02 August 2022, 08:50 GMT
Reason for closing:  Fixed
Additional comments about closing:  linux 5.18.13.arch1-1
Comment by Ronan Pigott (Brocellous) - Monday, 04 July 2022, 21:06 GMT Comment by Jonathon (jonathon) - Friday, 08 July 2022, 19:38 GMT
Pretty certain this is fixed in 5.18.10 if someone wants to verify.
Comment by Jan Ole Zabel (joz) - Saturday, 09 July 2022, 22:14 GMT
Sorry I did not answer in the other thread. An upgrade to 5.18.10 did not solve the problem for me.
Comment by Ronan Pigott (Brocellous) - Monday, 11 July 2022, 17:29 GMT
It's not fixed in 5.18.10.

Reading the new messages on the mailing list, it doesn't seem like there are any plans to fix it in the kernel. They are recommending updating samba.
Comment by Kevin (anonymous_user) - Friday, 15 July 2022, 03:29 GMT
Does that mean updating the samba on the server? I feel that will be a significant issue for users with NAS appliances.
Comment by Ronan Pigott (Brocellous) - Saturday, 16 July 2022, 00:54 GMT
Fixed by 32f319183c439b239294cb2d70ada3564c4c7c39 [1]. It applied cleanly to v5.18.11 for me and works too. Now we just wait for stable to cherry pick this.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=32f319183c439b239294cb2d70ada3564c4c7c39

Loading...