FS#75143 - [steam] Remove unneeded udev rules manipulation

Attached to Project: Community Packages
Opened by Emil (xexaxo) - Wednesday, 22 June 2022, 17:50 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:06 GMT
Task Type Bug Report
Category Packages: Multilib
Status Closed
Assigned To Levente Polyak (anthraxx)
Giancarlo Razzolini (grazzolini)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Description:

Current PKGBUILD's prepare stage manipulates (via sed) the udev rules bundled in the upstream tarball.
All of those changes have been present upstream [1] and are also part of the upstream tarball.

[1] https://github.com/ValveSoftware/steam-devices/

Additional info:
* package version(s)
steam 1.0.0.74-1

Steps to reproduce:
* Pull the steam upstream tarball and extract
* Visually inspect the udev rules and confirm the sed command in prepare() is a no-op
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:06 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/steam/issues/7
Comment by Emil (xexaxo) - Wednesday, 22 June 2022, 17:56 GMT
If anything the current sed commands create duplicate data isn't a good idea. For example:

$ cat /usr/lib/udev/rules.d/70-steam-vr.rules # double MODE
KERNEL=="hidraw*", SUBSYSTEM=="hidraw", ATTRS{idVendor}=="114d", ATTRS{idProduct}=="8a12", MODE="0660", MODE="0660", TAG+="uaccess"
...

$ grep static_node /usr/lib/udev/rules.d/70-steam-input.rules # double OPTIONS
KERNEL=="uinput", SUBSYSTEM=="misc", OPTIONS+="static_node=uinput", TAG+="uaccess", OPTIONS+="static_node=uinput"
Comment by Emil (xexaxo) - Friday, 17 March 2023, 14:43 GMT
Looking at the latest steam version `1.0.0.76-1` it still has the following lines. Can we remove them?

```
sed -r 's|("0666")|"0660", TAG+="uaccess"|g' -i subprojects/steam-devices/60-steam-input.rules
sed -r 's|("misc")|\1, OPTIONS+="static_node=uinput"|g' -i subprojects/steam-devices/60-steam-input.rules
sed -r 's|(, TAG\+="uaccess")|, MODE="0660"\1|g' -i subprojects/steam-devices/60-steam-vr.rules
```
Comment by Emil (xexaxo) - Wednesday, 21 June 2023, 13:43 GMT
Humble poke? Removing the sed lines and verifying the output should take much more than 2 minutes.

Is there anything I can do to move things forward? Be that here or in the other 5+ tasks I've opened.
Comment by Emil (xexaxo) - Tuesday, 12 September 2023, 08:48 GMT
Poke? Can we drop erroneous sed commands?

Loading...