FS#75112 - [coreutils] add a patch to fix unit test

Attached to Project: Arch Linux
Opened by Letu Ren (FantasqueX) - Sunday, 19 June 2022, 21:22 GMT
Last edited by Sébastien Luttringer (seblu) - Monday, 17 October 2022, 23:49 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Sébastien Luttringer (seblu)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Currently, coreutils fails to be built from source because of one unit test test-getlogin.

FAIL: test-getlogin
===================

test-getlogin.h:51: assertion '! isatty (0)' failed
FAIL test-getlogin (exit status: 134)

There is a bug report in ArchLinux about the same issue which has been closed because that issue should be reported to upstream. Ref: https://bugs.archlinux.org/task/66506

I reported to the upstream gnulib. A patch to skip this test has been merged.
Ref: https://lists.gnu.org/archive/html/bug-gnulib/2022-06/msg00001.html

I would like to add this patch to make sure that coreutils is able to be built from source successfully. The patch attached has been tested using `extra-x86_64-build`.
   fix-test-getlogin.patch (2.2 KiB)
   PKGBUILD.patch (0.7 KiB)
This task depends upon

Closed by  Sébastien Luttringer (seblu)
Monday, 17 October 2022, 23:49 GMT
Reason for closing:  Works for me
Comment by Toolybird (Toolybird) - Friday, 29 July 2022, 06:26 GMT
Interesting. Like @seblu in  FS#66506 , I do not see the test failure. I wonder why it fails for some and not others?

Edit: Ahh, it's skipped because "Skipping test: stdin is not a tty"

Loading...