FS#75050 - [rocksndiamonds] drop depends=smpeg; unneded (app uses SDL2_mixer)

Attached to Project: Community Packages
Opened by Marcell Meszaros (MarsSeed) - Sunday, 12 June 2022, 18:10 GMT
Last edited by Sergej Pupykin (sergej) - Tuesday, 14 June 2022, 17:38 GMT
Task Type Support Request
Category Packages
Status Closed
Assigned To No-one
Architecture x86_64
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: [rocksndiamonds] is built with SDL2 libraries.
Therefore the SDL1 based [smpeg] 0.4.5 is not needed for MP3 playback.

From INSTALL file: [1]
"To compile the game, you need the SDL library (version 2). In addition, you
also need the libraries SDL_image, SDL_mixer (with optional support for MOD,
MP3 and MIDI music) and SDL_net"

[smpeg] 0.4.5 is only compatible with SDL1 [2], and smpeg 2.0.0 for SDL2 [3]
is not in Arch repos.

But [rocksndiamonds] depends on [sdl2_mixer] [4], and that uses [mpg123]
for MP3 playback [5].


Additional info:
* package version(s): rocksndiamonds 4.3.2.0-1


References:
[1] https://git.artsoft.org/?p=rocksndiamonds.git;a=blob;f=INSTALL;hb=refs/tags/4.3.2.1
[2] https://github.com/icculus/smpeg/blob/release_0_4_5/README#L29
[3] https://github.com/icculus/smpeg/blob/c5793e5f3f2765fc09c24380d7e92136a0e33d3b/README#L29
[4] https://archlinux.org/packages/community/x86_64/rocksndiamonds/
[5] https://archlinux.org/packages/extra/x86_64/sdl2_mixer/


Additional suggestive evidence (ignore the last two warnings):

$ namcap /var/cache/pacman/pkg/rocksndiamonds-4.3.2.0-1-x86_64.pkg.tar.zst
rocksndiamonds W: ELF file ('usr/bin/rocksndiamonds') lacks FULL RELRO, check LDFLAGS.
rocksndiamonds W: Dependency sdl2 included but already satisfied
rocksndiamonds W: Dependency included and not needed ('smpeg')
rocksndiamonds W: Dependency included and not needed ('rocksndiamonds-data')
rocksndiamonds W: Dependency included and not needed ('rocksndiamonds-contrib')
This task depends upon

Closed by  Sergej Pupykin (sergej)
Tuesday, 14 June 2022, 17:38 GMT
Reason for closing:  Fixed

Loading...