FS#74909 - [helix] Fish shell completition broken

Attached to Project: Community Packages
Opened by diazkun (diaz) - Monday, 30 May 2022, 18:39 GMT
Last edited by Toolybird (Toolybird) - Saturday, 16 July 2022, 02:48 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To No-one
Architecture x86_64
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

When trying to autocomplete the command `helix` using fish shell by pressing <TAB>,
fish throws errors about about unknown command `hx`.

The shell completions seem to come from upstream at https://github.com/helix-editor/helix/tree/master/contrib/completion expecting the binary to be called `hx` but in arch packaging the binary is changed to `helix` and the completion files renamed to be `helix.$SHELL`, but the `helix.fish` still contains references to the expected `hx` command which makes completion fail by default, which is unexpected behavior.

Additional info:
* package version(s) tested with latest - 22.05-2
* config and/or log files etc. -
no additional configs, just default install.

Error message on fish shell:

❯ helix fish: Unknown command: hx
/usr/share/fish/vendor_completions.d/helix.fish (line 1):
hx --health |tail -n '+7' |awk '{print $1}' |sed 's/\x1b\[[0-9;]*m//g'
^
in command substitution
called on line 4 of file /usr/share/fish/vendor_completions.d/helix.fish
from sourcing file /usr/share/fish/vendor_completions.d/helix.fish
in command substitution
/usr/share/fish/vendor_completions.d/helix.fish (line 4): Unknown command
set -l langs (hx --health |tail -n '+7' |awk '{print $1}' |sed 's/\x1b\[[0-9;]*m//g')
^
from sourcing file /usr/share/fish/vendor_completions.d/helix.fish
in command substitution

Steps to reproduce:
- install package
- open a fish interactive shell
- press tab after writing `helix`

(haven't verified other shells completion files if they have the same problem or not)
This task depends upon

Closed by  Toolybird (Toolybird)
Saturday, 16 July 2022, 02:48 GMT
Reason for closing:  Fixed
Additional comments about closing:  helix 22.05-3

Loading...