Arch Linux

Description:

When running metaflac to set tags in .flac files, and passing in
non-ASCII values for the vorbis comments fields, all non-ASCII
characters are replaced with fallback characters. One option is
to pass in the --no-utf8-convert option or to set the CHARSET
environment variable to UTF-8, but this wouldn't be needed
if the package were compiled with HAVE_LANGINFO_CODESET defined.

The bug happens in the current_charset() function in utf8.c[1];
if compiled without -DHAVE_LANGINFO_CODESET=ON, the function
only looks at the CHARSET environment variable and falls back
to US-ASCII if it's undefined.

I tested that adding -DHAVE_LANGINFO_CODESET=ON to the PKGBUILD
solves the issue.

[1] https://github.com/xiph/flac/blob/1.3.4/src/share/utf8/utf8.c#L133-L144

Additional info:

Package version 1.3.4-2

Steps to reproduce:

1. copy some flac file to /tmp/test.flac
2. metaflac /tmp/test.flac --set-tag ARTIST="DJ Krush" --set-tag ALBUM="漸 -Zen-"
3. metaflac /tmp/test.flac --list --block-type VORBIS_COMMENT

With a metaflac compiled without HAVE_LANGINFO_CHARSET, step 2 puts
in the '#' fallback character for non-ASCII bytes in the metadata,
and step 3 outputs the '?' as fallback for non-ASCII bytes.

In case Flyspray mangles the second step, a Unicode-safe invocation (from Bash) is:

metaflac /tmp/test.flac --set-tag ARTIST="DJ Krush" --set-tag ALBUM=$'\u6F38 -Zen-'