FS#74565 - [synergy] 1.10.3-3 aborts

Attached to Project: Community Packages
Opened by Jake Barnes (DuBistKomisch) - Tuesday, 26 April 2022, 10:50 GMT
Last edited by Toolybird (Toolybird) - Sunday, 11 June 2023, 23:06 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Levente Polyak (anthraxx)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Running synergyd directly or via systemd results in an abort, regardless of config file. Downgrading back to 1.10.3-2 works.

Additional info:

$ synergys --no-daemon
/usr/include/c++/11.2.0/bits/stl_vector.h:1045: std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::operator[](std::vector<_Tp, _Alloc>::size_type) [with _Tp = unsigned char; _Alloc = std::allocator<unsigned char>; std::vector<_Tp, _Alloc>::reference = unsigned char&; std::vector<_Tp, _Alloc>::size_type = long unsigned int]: Assertion '__n < this->size()' failed.
Aborted (core dumped)

Apr 26 20:38:22 tantalum systemd[1177]: Started Synergy Server Daemon.
Apr 26 20:38:22 tantalum systemd-coredump[51884]: [🡕] Process 51880 (synergys) of user 1000 dumped core.
...
Apr 26 20:38:22 tantalum systemd[1177]: synergys.service: Main process exited, code=dumped, status=6/ABRT
Apr 26 20:38:22 tantalum systemd[1177]: synergys.service: Failed with result 'core-dump'.

I can attach the dump etc, but the stack trace doesn't seem particular meaningful.

Steps to reproduce:

Run `synergys --no-daemon`.
This task depends upon

Closed by  Toolybird (Toolybird)
Sunday, 11 June 2023, 23:06 GMT
Reason for closing:  Upstream
Additional comments about closing:  Please follow up with upstream.
Comment by Jake Barnes (DuBistKomisch) - Sunday, 06 November 2022, 07:21 GMT
The OpenSSL 3 upgrade broke downgrading to 1.10.3-2, so I had to actually look into this.

Turns out it's just a legit out-of-bounds write to a vector triggering the assertion.

I've submitting fixes upstream for synergy [1] and barrier [2].

[1]: https://github.com/symless/synergy-core/pull/7236
[2]: https://github.com/debauchee/barrier/pull/1827
Comment by Toolybird (Toolybird) - Tuesday, 04 April 2023, 23:22 GMT
Still happening with synergy 1.11.1-1?
Comment by Jake Barnes (DuBistKomisch) - Wednesday, 12 April 2023, 03:57 GMT
Just tried it and yes, which makes sense since the fix hasn't been accepted yet. I'm more surprised it's not happening for everyone?
Comment by Toolybird (Toolybird) - Friday, 12 May 2023, 02:56 GMT
> the fix hasn't been accepted yet

apparently because it needs more work and you said "I'll update when I have time"...

Loading...