Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#74514 - [gitlab-shell] `fsyncObjectFiles` is deprecated

Attached to Project: Community Packages
Opened by simonzack (simonzack) - Wednesday, 20 April 2022, 06:28 GMT
Last edited by Jonas Witschel (diabonas) - Wednesday, 22 June 2022, 12:16 GMT
Task Type Bug Report
Category Packages
Status Assigned   Reopened
Assigned To Anatol Pomozov (anatolik)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 2
Private No

Details

Description:

When I push, I get the error:

warning: core.fsyncObjectFiles is deprecated; use core.fsync instead

`/etc/webapps/gitlab-shell/.gitconfig` should be modified to include something other than `fsyncObjectFiles`.

Additional info:
* package version(s) 3:13.25.0-1

Steps to reproduce:

- Push to a *Git* repository.
This task depends upon

Comment by Anatol Pomozov (anatolik) - Friday, 29 April 2022, 17:45 GMT
Thank you for reporting it. It is fixed in SVN.
Comment by Jakub Klinkovský (lahwaacz) - Wednesday, 22 June 2022, 12:16 GMT
  • Field changed: Percent Complete (100% → 0%)
The referenced commit only replaced "fsyncObjectFiles = true" with "fsync = true", but fsync is not a boolean option. This leads to warnings like "warning: ignoring unknown core.fsync component 'true'" when e.g. pushing into a repository. It should be replaced with e.g. "fsync = all", see https://man.archlinux.org/man/git-config.1
Comment by Jakub Klinkovský (lahwaacz) - Wednesday, 22 June 2022, 12:16 GMT
  • Field changed: Percent Complete (100% → 0%)
The referenced commit only replaced "fsyncObjectFiles = true" with "fsync = true", but fsync is not a boolean option. This leads to warnings like "warning: ignoring unknown core.fsync component 'true'" when e.g. pushing into a repository. It should be replaced with e.g. "fsync = all", see https://man.archlinux.org/man/git-config.1
Comment by Anatol Pomozov (anatolik) - Wednesday, 22 June 2022, 15:31 GMT
D'oh, thanks for the report.


Another option is to leave this option to the platform default. Per the manpage

====
The empty string resets the fsync configuration to the platform default. The default on most platforms is equivalent to core.fsync=committed,-loose-object, which has good performance, but risks losing recent work in the event of an unclean system shutdown.
====
Comment by Jakub Klinkovský (lahwaacz) - Wednesday, 22 June 2022, 15:41 GMT
There is also this comment in /etc/gitlab-gitaly/config.toml since gitlab-gitaly-15.1.0-1:

# # Set this setting to `true` to start ignoring gitconfig files installed in
# # the system. This includes both system-level (e.g. '/etc/gitconffig') and
# # global-level (e.g. `$HOME/.gitconfig`) files. This setting will become the
# # default with v16.0. If you intend to override Git configuration you can do
# # so via `[[git.config]]`. The default value is `false`.
# ignore_gitconfig = false

Loading...