FS#74467 - [cargo-edit] cherry-pick a commit to fix a test failure in Cargo 1.60.x

Attached to Project: Community Packages
Opened by Sprite (Sprite) - Thursday, 14 April 2022, 15:43 GMT
Last edited by Orhun Parmaksız (orhun) - Saturday, 30 April 2022, 12:21 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Kyle Keen (keenerd)
Caleb Maclennan (alerque)
Orhun Parmaksız (orhun)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Cargo v1.60.0 has been released and packaged, and some error formats have been changed. One test of this package relied on an old error message that caused a test to fail in Cargo v1.60.0 (and higher).

The attached patch cherry-picked a commit to fix the problem.

Upstream PR: https://github.com/killercup/cargo-edit/pull/693

Log of the test failure:

```
Testing tests/cmd/upgrade/invalid_workspace_root_manifest.toml ... failed
Exit: 1
stdout:


---- expected: stderr
++++ actual: stderr
1 1 | Error: Failed to get workspace metadata
2 2 |
3 3 | Caused by:
4 4 | `cargo metadata` exited with an error: error: failed to parse manifest at `[CWD]/Cargo.toml`
5 5 |
6 6 | Caused by:
7 7 | could not parse input as TOML
8 8 |
9 9 | Caused by:
10 - expected an equals, found an identifier at line 1 column 6
10 + TOML parse error at line 1, column 6
11 + |
12 + 1 | This is clearly not a valid Cargo.toml.
13 + | ^
14 + Unexpected `i`
15 + Expected `.` or `=`
```
This task depends upon

Closed by  Orhun Parmaksız (orhun)
Saturday, 30 April 2022, 12:21 GMT
Reason for closing:  Implemented

Loading...