FS#74338 - [broadcom-wl-dkms] Patch for 5.17 Should Be Updated

Attached to Project: Community Packages
Opened by Andrei Măceș (amaces) - Monday, 04 April 2022, 09:18 GMT
Last edited by Jan Alexander Steffens (heftig) - Monday, 30 May 2022, 18:39 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Alexander F. Rødseth (xyproto)
Jan Alexander Steffens (heftig)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Description:
Current `012-linux517.patch` is missing `eth_hw_addr_set` in a couple of places, which still leads to kernel issues (https://bugs.launchpad.net/ubuntu/+source/bcmwl/+bug/1961801/comments/3). A better patch is at (https://gist.github.com/joanbm/37fd0590f30b41e7e89ade6e242ca16e).

Additional info:
* Ubuntu bug report: (https://bugs.launchpad.net/ubuntu/+source/bcmwl/+bug/1961801)

Steps to reproduce:
* Load module.
This task depends upon

Closed by  Jan Alexander Steffens (heftig)
Monday, 30 May 2022, 18:39 GMT
Reason for closing:  Fixed
Additional comments about closing:  broadcom-wl-dkms 6.30.223.271-31
Comment by Mathieu (mathdu07) - Tuesday, 19 April 2022, 15:56 GMT
I can confirm that applying this patch instead of the current `012-linux517.patch` removes the warning "netdevice: wlo1: Incorrect netdev->dev_addr" for the current version of the package (6.30.223.271-29).
Comment by Andrei Măceș (amaces) - Thursday, 28 April 2022, 11:00 GMT
Another option is the set of following patches:
https://github.com/antoineco/broadcom-wl/commit/ac70fe944bd96ccf379d238317e3f2013f41a968.patch
https://github.com/antoineco/broadcom-wl/commit/df12b9a8e87d9103a2a39c9353881cc9b4adfbba.patch

Still, I believe that Joan Bruguera's patch (https://gist.github.com/joanbm/37fd0590f30b41e7e89ade6e242ca16e) is cleanest.
Comment by Paul Mulders (justinkb) - Saturday, 28 May 2022, 22:03 GMT
I actually like those patches from antoine better fwiw. using the conditional instead of the define for the PDE_DATA->pde_data seems better, and using the proposed dev_addr_mod as suggested by linux kernel devs for the other thing seems better, too.

Loading...