FS#74333 - [sigal] 2.2-2 breaks when used with python-click 8.1

Attached to Project: Community Packages
Opened by Renan Ramos (japareaggae) - Monday, 04 April 2022, 01:52 GMT
Last edited by David Thurstenson (thurstylark) - Sunday, 10 April 2022, 11:00 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To No-one
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

sigal 2.2 uses the get_terminal_size function from python-click, which was removed in python-click 8.1. As such, sigal is completely broken and fails to run at all.
A commit fixing this deprecation was already published in the sigal's master branch: <https://github.com/saimn/sigal/commit/29f69bc55caf40798fd00c2beac31b8a2826d8e9>
This commit should be backported to the sigal package in order to fix it.

Package versions:
sigal 2.2-2, python-click 8.1.2-1

Steps to reproduce:
Run "sigal"

Traceback:
% sigal init
Traceback (most recent call last):
File "/usr/bin/sigal", line 33, in <module>
sys.exit(load_entry_point('sigal==2.2', 'console_scripts', 'sigal')())
File "/usr/bin/sigal", line 25, in importlib_load_entry_point
return next(matches).load()
File "/usr/lib/python3.10/importlib/metadata/__init__.py", line 171, in load
module = import_module(match.group('module'))
File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 883, in exec_module
File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
File "/usr/lib/python3.10/site-packages/sigal/__init__.py", line 33, in <module>
from .gallery import Gallery
File "/usr/lib/python3.10/site-packages/sigal/gallery.py", line 39, in <module>
from click import get_terminal_size, progressbar
ImportError: cannot import name 'get_terminal_size' from 'click' (/usr/lib/python3.10/site-packages/click/__init__.py)
This task depends upon

Closed by  David Thurstenson (thurstylark)
Sunday, 10 April 2022, 11:00 GMT
Reason for closing:  Fixed
Additional comments about closing:  sigal 2.3-1
Comment by Renan Ramos (japareaggae) - Friday, 08 April 2022, 22:20 GMT
Fixed with the release of sigal 2.3-1.

Loading...