FS#73961 - [toolchain] minor PKGBUILD cleanups

Attached to Project: Arch Linux
Opened by Toolybird (Toolybird) - Friday, 25 February 2022, 22:15 GMT
Last edited by freswa (frederik) - Wednesday, 02 March 2022, 22:53 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To freswa (frederik)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Just some incidental stuff I noticed while working through the latest updates.

A couple of things here are due to confusion surrounding the top-level configury which is shared between binutils, gcc, gdb, etc.

binutils:
- CPPFLAGS hack no longer needed
- `--enable-lto' is only applicable to the GCC build (per note above re top-level). It does nothing for binutils and should be dropped. In the GCC build it defaults to "on" anyway.
- Netware support was removed in 2018 [1]

gcc:
- CPPFLAGS hack no longer needed
- `--enable-pgo-build=lto' is only applicable to binutils. There is no reference to it in the 11.2 tarball. In fact, if you try to use it on GCC trunk it errors out.

glibc:
- spello
- tweak the comment about systemd-nspawn and syscalls in the testsuite. "--capability=CAP_IPC_LOCK" is too overly broad. Not sure what I was thinking back then, or things might have changed since.
- fix optdepends
- remove /etc/ld.so.conf hack. It was only there to get rid of a warning which has now been fixed upstream [2]
- remove commands rm'ing libcrypt which of course is now disabled in glibc build

linux-api-headers:
- `make headers_check' is deprecated with big fat warning and is going away soon

[1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=b4b594e3
[2] https://sourceware.org/git/?p=glibc.git;a=commit;h=b5a1271c
This task depends upon

Closed by  freswa (frederik)
Wednesday, 02 March 2022, 22:53 GMT
Reason for closing:  Implemented
Additional comments about closing:  Thank you :)
Comment by freswa (frederik) - Friday, 25 February 2022, 23:52 GMT
You are awesome :) I'll look into it on the weekend and I'll incorporate the changes :)
Comment by Allan McRae (Allan) - Saturday, 26 February 2022, 05:42 GMT
Thanks Toolybird. I'll note that quite a few of these were posted in earlier bug reports...
Comment by Allan McRae (Allan) - Saturday, 26 February 2022, 05:57 GMT
The optdepend change from glibc should really move the perl optdepend into the glibc package as the mtrace "binary" is in glibc.
Comment by freswa (frederik) - Wednesday, 02 March 2022, 21:45 GMT
Wrt binutils, `--enable-lto` seems supported: https://github.com/bminor/binutils-gdb/blob/master/configure#L1533
Comment by loqs (loqs) - Wednesday, 02 March 2022, 22:20 GMT
Is the --enable-lto not ignored though as --enable-pgo-build=lto is also specified? https://github.com/bminor/binutils-gdb/commit/af019bfde9b13d628202fe58054ec7ff08d92a0f
Comment by Toolybird (Toolybird) - Wednesday, 02 March 2022, 22:25 GMT
> `--enable-lto` seems supported

You appear to have missed my comment about the top-level configury being shared :)

Verification. Build once with, then again without, and compare binary diff.
Comment by freswa (frederik) - Wednesday, 02 March 2022, 22:50 GMT
Got it :)

Loading...