FS#73940 - [onionshare] chat functionality broken 2.5

Attached to Project: Community Packages
Opened by helle vaanzinn (glitsj16) - Thursday, 24 February 2022, 01:16 GMT
Last edited by kpcyrd (kpcyrd) - Friday, 01 April 2022, 16:22 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To kpcyrd (kpcyrd)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
OnionShare's chat functionality is broken in 2.5-1.
The app does not crash but becomes pretty much unusable after clicking the 'Start
Chatting' item.

Downgrading to 2.4-1 revives the lost functionality but has several security issues that
2.5 supposedly fixed (cfr. https://github.com/onionshare/onionshare/releases/tag/v2.5).
I only downgraded to check the chat feature, which I never used before, and wouldn't
recommend that obviously.

Additional info:
* package version(s)
$ pacman -Q onionshare
onionshare 2.5-1
* config and/or log files etc.
Outout is available in the upstream bug report, but here it is:
$ onionshare -v
[...]
Traceback (most recent call last):
File "/usr/lib/python3.10/site-packages/onionshare/tab/tab.py", line 371, in chat_mode_clicked
self.chat_mode.init()
File "/usr/lib/python3.10/site-packages/onionshare/tab/mode/chat_mode/__init__.py", line 44, in init
self.web = Web(self.common, True, self.settings, "chat")
File "/usr/lib/python3.10/site-packages/onionshare_cli/web/web.py", line 171, in __init__
self.socketio.init_app(self.app)
File "/usr/lib/python3.10/site-packages/flask_socketio/__init__.py", line 245, in init_app
self.server = socketio.Server(**self.server_options)
File "/usr/lib/python3.10/site-packages/socketio/server.py", line 127, in __init__
self.eio = self._engineio_server_class()(**engineio_options)
File "/usr/lib/python3.10/site-packages/engineio/server.py", line 145, in __init__
raise ValueError('Invalid async_mode specified')
ValueError: Invalid async_mode specified

* link to upstream bug report, if any

https://github.com/onionshare/onionshare/issues/1531

Steps to reproduce:

1. start onionshare from terminal
$ onionshare -v
2. click the 'Start Chatting' item
3. check terminal output and see it hang
This task depends upon

Closed by  kpcyrd (kpcyrd)
Friday, 01 April 2022, 16:22 GMT
Reason for closing:  Fixed
Additional comments about closing:  Thanks, fixed in 2.5-2
Comment by helle vaanzinn (glitsj16) - Monday, 28 March 2022, 04:16 GMT
UPDATE: upstream marked this as a duplicate of https://github.com/onionshare/onionshare/issues/1510.
The package is missing a dependency on python-gevent-websocket.
I can confirm chat functionality is working as expected after installing that.

Loading...