FS#73716 - [gjs] valgrind in checkdepends but doesn't actually use in check.
Attached to Project:
Arch Linux
Opened by cubercsl (cubercsl) - Thursday, 10 February 2022, 12:24 GMT
Last edited by Jan Alexander Steffens (heftig) - Friday, 11 February 2022, 23:01 GMT
Opened by cubercsl (cubercsl) - Thursday, 10 February 2022, 12:24 GMT
Last edited by Jan Alexander Steffens (heftig) - Friday, 11 February 2022, 23:01 GMT
|
Details
Description:
According to upstream [hacking guide](https://gitlab.gnome.org/GNOME/gjs/-/blob/1.70.1/doc/Hacking.md#valgrind) and [CI config](https://gitlab.gnome.org/GNOME/gjs/-/blob/1.70.1/.gitlab-ci.yml#L346-356), running the test suite under Valgrind's memcheck tool should use args `--setup=valgrind`, but it doesn't actually do this in check. Is it necessary for us to use valgrind to check for memory leaks. If not, should valgrind be removed from the checkdepends? |
This task depends upon
Closed by Jan Alexander Steffens (heftig)
Friday, 11 February 2022, 23:01 GMT
Reason for closing: Fixed
Additional comments about closing: 1.70.1-2
Friday, 11 February 2022, 23:01 GMT
Reason for closing: Fixed
Additional comments about closing: 1.70.1-2
[2] https://gitlab.gnome.org/GNOME/gjs/-/blob/1.70.1/.gitlab-ci.yml#L346-356