FS#73522 - [libvirt] misc fixes for version 8.0.0
Attached to Project:
Community Packages
Opened by Toolybird (Toolybird) - Thursday, 27 January 2022, 01:39 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Monday, 31 January 2022, 02:22 GMT
Opened by Toolybird (Toolybird) - Thursday, 27 January 2022, 01:39 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Monday, 31 January 2022, 02:22 GMT
|
Details
Some noteworthy bugs were uncovered post-release. It would
be nice to have the fixes applied:
- Snapshot revert is broken [1]. I've also seen this reported on reddit. - Some API is broken which affects virt-install [2]. There are some other issues with the PKGBUILD: - radvd should be removed from optdepends. All code dealing with radvd was recently removed here [3]. The functionality is now provided by dnsmasq. - the sed stripping out the auto-generated UUID should be removed. It was fixed upstream [4] a while ago. The associated .install scriptlet should also be removed. - the sed that changes libvirtd.service Type= from "notify" to "simple" should be dropped. The origins of this date back almost 6 years to [4] and the conditions detailed in the bug report [5] are no longer valid. libvirt switched to a home grown sd_notify replacement here [6]. If I'm reading the systemd man page correctly, "simple" is definitely the wrong choice for libvirtd and we shouldn't be overriding upstream. Here is a patch implementing all of the above: https://gitlab.com/-/snippets/2242634 (careful, Gitlab snippet seems to mangle the patch a little by omitting the trailing linefeed char resulting in fuzz) Please also "git rm ..." the outdated files (Changelog, find_programs.ini and libvirt.install) [1] https://gitlab.com/libvirt/libvirt/-/issues/266 [2] https://bugzilla.redhat.com/show_bug.cgi?id=2041610 [3] https://gitlab.com/libvirt/libvirt/-/commit/b4efa0cf [4] https://github.com/archlinux/svntogit-community/commit/c2d223b [5] [6] https://gitlab.com/libvirt/libvirt/-/commit/c0bc1723 |
This task depends upon
Closed by Sven-Hendrik Haase (Svenstaro)
Monday, 31 January 2022, 02:22 GMT
Reason for closing: Fixed
Monday, 31 January 2022, 02:22 GMT
Reason for closing: Fixed
> the sed stripping out the auto-generated UUID should be removed. It was fixed upstream [4]
make that number [7]
[7] https://gitlab.com/libvirt/libvirt/-/commit/6e8f28dc
Ugh, that was my fault. I forgot that bash command substitution gobbles trailing new lines.
TIL that python-gitlab will accept @filename syntax ie: --content @myfile
Here's a proper patch:
https://gitlab.com/-/snippets/2242696
Sorry for the noise.