FS#73502 - [polkit] Switch to Duktape as Javascript engine

Attached to Project: Arch Linux
Opened by tinywrkb (tinywrkb) - Tuesday, 25 January 2022, 17:10 GMT
Last edited by Toolybird (Toolybird) - Tuesday, 02 August 2022, 23:27 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jan Alexander Steffens (heftig)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Duktape support was merged https://gitlab.freedesktop.org/polkit/polkit/-/merge_requests/97 and there's nothing else before that in master since latest stable, so I suggest building from the merge commit, and dropping mozjs depedency.
This needs duktape fixes from https://bugs.archlinux.org/task/73500, meson patch from https://gitlab.freedesktop.org/polkit/polkit/-/merge_requests/99, and `-D js_engine=duktape` configure option.
This task depends upon

Closed by  Toolybird (Toolybird)
Tuesday, 02 August 2022, 23:27 GMT
Reason for closing:  Fixed
Additional comments about closing:  polkit 121-1
Comment by tinywrkb (tinywrkb) - Tuesday, 25 January 2022, 17:40 GMT
Note that during build time, there are a couple of warnings about FORTIFY_SOURCE when generating GIRs. I'm not sure if this is safe to ignore.
Comment by test0 (test0) - Thursday, 27 January 2022, 05:57 GMT
Please do it!
Comment by Jan Alexander Steffens (heftig) - Friday, 11 February 2022, 22:26 GMT
I'd rather not we jump the gun here, especially if Duktape needs patches to work properly. This makes it sound like a poor choice compared to mozjs.

I plan to use js91 with the next polkit release.
Comment by tinywrkb (tinywrkb) - Friday, 11 February 2022, 22:28 GMT
@heftig, duktape's packaging needs to be fixed, not duktape. Sorry for the incorrect wording.
Comment by Yann Le Doaré (yledoare) - Monday, 21 February 2022, 10:50 GMT
Fixed into gentoo : https://bugs.gentoo.org/734326

Loading...