FS#73411 - [zstd] v1.5.1-2 pkg-config file incorrect, patch attached

Attached to Project: Community Packages
Opened by Ruijie Yu (ruijieyu) - Wednesday, 19 January 2022, 01:18 GMT
Last edited by Andreas Radke (AndyRTR) - Wednesday, 19 January 2022, 06:01 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To No-one
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Hello, I have found out today that zstd ships with an incorrect file `/usr/lib/pkgconfig/libzstd.pc`. It contains the line `prefix=/usr/local` but it should really be `prefix=/usr`.

Steps to reproduce:

Run `pkg-config --libs libzstd`, expecting to see `-L/usr/lib -lzstd`, but seeing `-L/usr/local/lib -lzstd`.

Additional info:
* package version(s)
* config and/or log files etc.
* link to upstream bug report, if any

See https://aur.archlinux.org/packages/guile-zstd/#comment-847526 for further discussion, where packages depending on pkg-config + libzstd fails to build because it cannot locate these files under `/usr/local/lib`.

From this, I have attached a patch as my attempt to solve the problem. It overrides the PREFIX variable in `make` in the `build` function. I am not sure whether that variable needs to be set for other invocations of `make` (and I don't know how to check it), but hopefully the patch should be a good starting point.

Trimmed down output of `pacman -Qii zstd`:

```
Version : 1.5.1-2
Provides : libzstd.so=1-64
Packager : Jelle van der Waa <jelle@archlinux.org>
Build Date : Fri 24 Dec 2021 04:18:59 AM CST
```

Thanks.
   zstd-no-local.patch (0.3 KiB)
This task depends upon

Closed by  Andreas Radke (AndyRTR)
Wednesday, 19 January 2022, 06:01 GMT
Reason for closing:  Duplicate
Additional comments about closing:   FS#73333 
Comment by Ruijie Yu (ruijieyu) - Wednesday, 19 January 2022, 01:24 GMT
Upon further searching, I noticed that https://bugs.archlinux.org/task/73333 reports the same issue. Therefore I think this bug request is no longer needed and I will instead watch the aforementioned request for updates.

Loading...