Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#73381 - Varnish package improvement

Attached to Project: Arch Linux
Opened by guillaume quintard (gquintard) - Sunday, 16 January 2022, 19:45 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Monday, 31 January 2022, 07:19 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Hi,

The Varnish project recently (and finally) added Arch packaging to https://github.com/varnishcache/pkg-varnish-cache/. Notably, we imported `varnish.sysusers` from the Arch repository, so you wouldn't have to maintain it yourselves, but we also found what we believe are (minor) issues. I'm listing them here convenience so you can decide whether they are worth integrating to the official package.

- varnish.sysusers: missing users means varnish keeps running as root
- depends: gcc is already part of base-devel, so it shouldn't be needed
- prepare: no need for autogen.sh since it's a dist tarball, configure is already built
- check: we restored it as the tests pass and are faster now, but there may have been another reason for disabling them
- package: builtin.vcl is already installed by autotools

Please let me know if any of these is misguided, I'll be happy to fix them
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Monday, 31 January 2022, 07:19 GMT
Reason for closing:  Fixed
Comment by Sven-Hendrik Haase (Svenstaro) - Monday, 31 January 2022, 03:07 GMT
In my understanding, varnish needs gcc at runtime. base-devel is a group which does indeed include gcc but is by no means assumed to be installed on the server systems that I assume to be running varnish. We therefore have to specify it separately. I would therefore urge you to explicitly depend on gcc in your package in case my earlier assumption of varnish requiring gcc is still correct.

Thanks for upstreaming varnish.sysusers. I'll make use of it going forward.

I'm also removing the prepare() function.

I'm also removing the manual installation of builtin.vcl.

However, for some reason, the check() won't execute without issues. I always get a failure here: FAIL: tests/m00000.vtc. Is there any way I can get you more detailed debug information on that? Alternatively, can I somehow mark that test to be skipped?
Comment by guillaume quintard (gquintard) - Monday, 31 January 2022, 03:34 GMT
Ah, good point about gcc, I completely missed that point, I will add it back.

Regarding the failed test, could you please run make check VERBOSE=1" and share the output, this should provide decent logs to debug. The brutal workaround is to just delete the file (bin/varnishtest/tests/m0000.vtc") in prepare(), but let's see if we can fix it first
Comment by Sven-Hendrik Haase (Svenstaro) - Monday, 31 January 2022, 04:21 GMT
Here's a full log.
   log.txt (165.7 KiB)
Comment by guillaume quintard (gquintard) - Monday, 31 January 2022, 05:53 GMT
ah, found it: https://github.com/varnishcache/varnish-cache/commit/d26b130534629254a76f1603064ca8e7abaa2faf
That means it will be in the next release. For the time being, you can either rm th file or apply the patch, as you prefer
Comment by Sven-Hendrik Haase (Svenstaro) - Monday, 31 January 2022, 06:42 GMT
Alright thanks! Please have a look at the current package and see whether it looks alright to you and then I shall close the bug.
Comment by guillaume quintard (gquintard) - Monday, 31 January 2022, 06:45 GMT
looking good, thanks for handling this!

Loading...