FS#73316 - [grub] Remove unneeded _gnulib_commit from PKGBUILD

Attached to Project: Arch Linux
Opened by Peter Wu (Lekensteyn) - Sunday, 09 January 2022, 23:24 GMT
Last edited by Christian Hesse (eworm) - Tuesday, 08 February 2022, 16:49 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Christian Hesse (eworm)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
The grub PKGBUILD references a specific gnulib commit. However, the "bootstrap.conf" script from grub references a specific commit, GNULIB_REVISION=d271f868a8df9bbec29049d01e056481b7a1a263.
(This feature was introduced with grub 2.04 via commit 35b909062e7b334eb4af372be3260d0f62d85375.)

To avoid any confusion about the gnulib version in use, I would recommend removing it (see attached patch).


Additional info:
* package version: grub 2:2.06-3


Steps to reproduce:

$ makepkg -os
...
==> Extracting sources...
-> Creating working copy of grub git repo...
Reset branch 'makepkg'
-> Creating working copy of gnulib git repo...
Updating files: 100% (9186/9186), done.
Previous HEAD position was d271f868a lock: Fix link error with --enable-threads=pth.
Switched to a new branch 'makepkg'
...
Avoid problem with unifont during compile of grub...
Run bootstrap...
./bootstrap: Bootstrapping from checked-out grub sources...
Updating files: 100% (9186/9186), done.
Note: switching to 'd271f868a8df9bbec29049d01e056481b7a1a263'.
...

$ git -C src/gnulib rev-parse HEAD
d271f868a8df9bbec29049d01e056481b7a1a263
This task depends upon

Closed by  Christian Hesse (eworm)
Tuesday, 08 February 2022, 16:49 GMT
Reason for closing:  Fixed
Additional comments about closing:  in svn

Loading...