FS#7329 - Root directory no longer prefixed to db/cache paths

Attached to Project: Pacman
Opened by Andrew Fyfe (space-m0nkey) - Friday, 01 June 2007, 04:38 GMT
Last edited by Roman Kyrylych (Romashka) - Thursday, 28 June 2007, 09:27 GMT
Task Type Bug Report
Category General
Status Closed
Assigned To Aaron Griffin (phrakture)
Dan McGee (toofishes)
Architecture All
Severity High
Priority Normal
Reported Version 3.0.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

When using `pacman -r <dir> ...` the root directory is no longer prefixed to the database/cache directories. e.g. (/tmp/foo is an empty folder)

$ sudo src/pacman/pacman.static -v -r /tmp/foo -A filesystem-0.8-8.pkg.tar.gz
Root : /tmp/foo/
Conf File : /etc/pacman.conf
Lock File : /var/run/pacman.lck
Root : /tmp/foo/
DBPath : /var/lib/pacman/
CacheDir : /var/cache/pacman/pkg/
Targets : filesystem-0.8-8.pkg.tar.gz
error: failed to add target 'filesystem-0.8-8.pkg.tar.gz' (package already installed)


Reported Version: git
This task depends upon

Closed by  Roman Kyrylych (Romashka)
Thursday, 28 June 2007, 09:27 GMT
Reason for closing:  Won't fix
Comment by Aaron Griffin (phrakture) - Friday, 01 June 2007, 05:41 GMT
http://projects.archlinux.org/git/gitweb.cgi?p=pacman.git;a=commit;h=7bd2ff685188d0d9b6ab6c6f43f6d28811936881
Comment by Andrew Fyfe (space-m0nkey) - Friday, 01 June 2007, 11:57 GMT
I've just re-read Dan's commit message, I don't like it :( I think root dir should still be prefixed to each path, unless the other options are specified on the command line e.g

pacman -r /foo
Root = /foo
DB = /foo/var/lib/pacman
Cache = /foo/var/cache/pacman
Lock File = /foo/var/run/pacman.lck
Config = /foo/etc/pacman.conf

pacman -r /foo --cachedir /var/cache/pacman --config /etc/pacman.conf
Root = /foo
DB = /foo/var/lib/pacman
Cache = /var/cache/pacman
Lock File = /foo/var/run/pacman.lck
Config = /etc/pacman.conf
Comment by Dan McGee (toofishes) - Saturday, 09 June 2007, 16:14 GMT
Just noticed that I made these changes and wasn't even assigned to the bug. :)

My reasoning was this- why should we make the decision where the cache, lockfile, and db lie when that is up to the user? The old way did not permit these three things to lie outside the root directory, the new way does (and still permits the old behavior). Having different behavior between the defaults (with a root prefix) and command line (w/o a root prefix) would be confusing and not KISS.

In short- the old way made assumptions that I thought were unfounded, so I removed them and now let the user choose everything.

Loading...