FS#72821 - [rpcbind] >= 0.2.4-2 arguments defined in RPCBIND_ARGS config variable are not passed to service

Attached to Project: Arch Linux
Opened by Dennis Herbrich (gyroplast) - Tuesday, 23 November 2021, 12:45 GMT
Last edited by Andreas Radke (AndyRTR) - Thursday, 02 December 2021, 20:00 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Andreas Radke (AndyRTR)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Affects package rpcbind >= 0.2.4-2, incl. current 1.2.6-1

Description:
Adding command-line arguments for rpcbind.service in the predefined RPCBIND_ARGS variable in the default /etc/conf.d/rpcbind is without effect to the command-line arguments passed to /usr/bin/rpcbind when the service is started.

The problem is that the rpcbind.service, as patched with the file systemd_service.diff based on upstream in version 0.2.4-2, resolves $RPCBIND_OPTIONS in ExecStart instead of the previous custom choice of RPCBIND_ARGS, so setting RPCBIND_ARGS in the sourced config file cannot be effective any longer.

Steps to reproduce:
1. Set RPCBIND_ARGS="-h 127.0.0.1" in /etc/conf.d/rpcbind
2. systemctl restart rpcbind.service
3. ps -C rpcbind -o command
COMMAND
/usr/bin/rpcbind -w -f

Expected:
ps -C rpcbind -o command
COMMAND
/usr/bin/rpcbind -h 127.0.0.1 -w -f

Trivial patch is attached to rename RPCBIND_ARGS to RPCBIND_OPTIONS in rpcbind.conf source file to re-establish consistency with the service and upstream, who uses _OPTIONS.

Note: as suggested by upstream, the config file setting should likely be set to optional from
EnvironmentFile=/etc/conf.d/rpcbind
to
EnvironmentFile=-/etc/conf.d/rpcbind
to stay consistent with the expectation of such a distribution configuration file being truly optional. I'm not going to fight for that, though, but maybe it's worth changing while you're at it.
This task depends upon

Closed by  Andreas Radke (AndyRTR)
Thursday, 02 December 2021, 20:00 GMT
Reason for closing:  Fixed
Additional comments about closing:  1.2.6-2
Comment by Dennis Herbrich (gyroplast) - Tuesday, 23 November 2021, 12:55 GMT
Errata: Reproduce with 127.0.0.2 instead of 127.0.0.1, as that triggers a known upstream double-free issue.

Loading...