FS#72768 - Unzip 6.0-15 breaks LineageOS builds

Attached to Project: Arch Linux
Opened by Scot Warner (Tortel1210) - Tuesday, 16 November 2021, 20:40 GMT
Last edited by Jonas Witschel (diabonas) - Wednesday, 17 November 2021, 13:47 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Lukas Fleischer (lfleischer)
Jonas Witschel (diabonas)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
With the 6.0-15 update to unzip, LineageOS (And most likely all AOSP builds) fail during a verification step due to a changes in unzip

The build system runs the following command:
`unzip -o -q /mnt/out/lineage18-out/lineage18/target/product/guacamole/obj/PACKAGING/target_files_intermediates/lineage_guacamole-target_files-eng.scott.zip -d /mnt/out/lineage18-out/lineage18/soong/.temp/targetfiles-4sDrjp SYSTEM/etc/vintf/* VENDOR/etc/vintf/* ODM/etc/vintf/* SYSTEM/system_ext/etc/vintf/* ODM/etc/* META/* */build.prop`

Between 6.0-14 and and 6.0-15 the behaviour of unzip changed for this command.
Attached is the listing of the zipfile, and the output of both the old/expected version (-14) vs new/incorrect version (-15).

I went through the patches introduced between 6.0-14 and 6.0-15, and have determined that the 'unzip-6.0-fix-recmatch.patch' is what changes the behaviour.
Additionally, the 'unzip-6.0-caseinsensitive.patch' does not apply without the recmatch patch.
   zip-contents.txt (435.4 KiB)
   unzip-14-output.txt (6.2 KiB)
   unzip-15-output.txt (2.9 KiB)
This task depends upon

Closed by  Jonas Witschel (diabonas)
Wednesday, 17 November 2021, 13:47 GMT
Reason for closing:  Fixed
Additional comments about closing:  unzip 6.0-16 in [testing]
Comment by Jonas Witschel (diabonas) - Tuesday, 16 November 2021, 21:19 GMT
Thank you for the detailed report! Since these patches don't fix any security issues, I am fine with dropping them if that makes unzip more compatible with the archives that LineageOS uses. Please try unzip 6.0-16 in [testing] and see if that fixes the issue.
Comment by Scot Warner (Tortel1210) - Wednesday, 17 November 2021, 02:55 GMT
Thanks, I was actually worried about not having enough detail and I also wanted to make it easy to figure out.

I can confirm that the testing version fixes the issue.
Comment by Jonas Witschel (diabonas) - Wednesday, 17 November 2021, 13:47 GMT
Thanks for confirming. I will wait for some signoffs on unzip 6.0-16 and then move it to the stable repositories.

Loading...