FS#72600 - [handbrake] fails to build with lto, options=('!lto') requested

Attached to Project: Community Packages
Opened by Devin Cofer (Ranguvar) - Monday, 01 November 2021, 03:18 GMT
Last edited by Evangelos Foutras (foutrelis) - Monday, 10 January 2022, 22:20 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Evangelos Foutras (foutrelis)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

Build with lto enabled in makepkg.conf fails linking stage.
It would be nice if we can add options=('!lto') to such packages.

If needed I can rebuild to get those logs, didn't save them.

Steps to reproduce:

1. Enable the lto option in makepkg.conf
2. Build handbrake
3. Fail at linker stage
4. Add options=('!lto') to PKGBUILD
5. Build successfully

Thank you!
This task depends upon

Closed by  Evangelos Foutras (foutrelis)
Monday, 10 January 2022, 22:20 GMT
Reason for closing:  Fixed
Additional comments about closing:  handbrake 1.5.1-1 (disabled LTO)
Comment by loqs (loqs) - Monday, 01 November 2021, 05:13 GMT
The package can be made to build with LTO enabled by disabling some assembly usage in the bundled ffmpeg and all assembly usage in the bundled libdav1d.
   PKGBUILD.diff (0.5 KiB)
Comment by Devin Cofer (Ranguvar) - Monday, 01 November 2021, 05:21 GMT
Thanks for that!

It seems like that would be more of a sacrifice than it's worth, no?

LTO is great and all, but I know some projects like x264 use a _ton_ of inline asm.

I don't know about ffmpeg specifically, or even if that then applies to its bundled libx264, so maybe someone with more information can comment.

Loading...