FS#72379 - [firefox-developer-edition] Invalid Wayland window icon on Plasma

Attached to Project: Community Packages
Opened by Francois (francoism90) - Sunday, 10 October 2021, 09:46 GMT
Last edited by Andrew Crerar (andrewSC) - Thursday, 08 September 2022, 16:58 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Andrew Crerar (andrewSC)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Description:
I tried multiple workarounds (editing the .desktop file), but still the FF Developer Edition is showing a generic Wayland window icon.

When installing and using FF (including force-enabling Wayland) the branding works fine.

Comparing both PKGBUILDs it does seem the the firefox pkg does some additional branding stuff.

Additional info:
* 94.0b3 (ff dev)
* 93.0 (ff)
* Plasma 5.22 unstable

Steps to reproduce:
* Install both versions
* Enable Wayland for both
* Incorrect icon displaying for Firefox Developer Edition.
This task depends upon

Closed by  Andrew Crerar (andrewSC)
Thursday, 08 September 2022, 16:58 GMT
Reason for closing:  Fixed
Additional comments about closing:  Introduced .desktop filename fix in 105.0b7.
Comment by Francois (francoism90) - Saturday, 23 October 2021, 18:36 GMT
This fixes the issues:

```
// PKGBUILD
# Branding
ac_add_options --enable-official-branding
ac_add_options --with-branding=browser/branding/aurora
ac_add_options --enable-update-channel=aurora
ac_add_options --with-distribution-id=org.archlinux
ac_add_options --with-unsigned-addon-scopes=app,system
ac_add_options --allow-addon-sideload
export MOZILLA_OFFICIAL=1
export MOZ_APP_REMOTINGNAME=firefox-developer-edition
export MOZ_TELEMETRY_REPORTING=1
export MOZ_REQUIRE_SIGNING=

// https://github.com/archlinux/svntogit-packages/blob/f6174036acaf7ea0703bb6fe25c2466237c56be7/trunk/PKGBUILD#L174
local i theme=aurora

// firefox-developer-edition.desktop
Exec=/usr/lib/firefox-developer-edition/firefox --class="firefox-developer-edition" // append to all `Exec` lines
StartupWMClass=firefox-developer-edition
```

@andrewSC Hope you can include these fixes. :)
Comment by Andrew Crerar (andrewSC) - Wednesday, 03 November 2021, 17:12 GMT
Can you let me know if 95.0b2 resolves the issue?
Comment by Francois (francoism90) - Thursday, 04 November 2021, 13:10 GMT
Unfortunately it doesn't, did you read the email I've send to you? :)

The desktop entry and classname need to match, otherwise it will not find the correct (icon) name.
Comment by Andrew Crerar (andrewSC) - Friday, 05 November 2021, 18:58 GMT
Hi Francois, I've made the updates to the desktop entry for 95.0b3. Would you mind testing and letting me know?
Comment by Kenneth (qufiwefefwoyn) - Friday, 08 July 2022, 01:44 GMT
  • Field changed: Percent Complete (100% → 0%)
Displays generic Wayland icon (KDE Plasma Wayland session). The only thing that fixed is renaming firefox-developer-edition.desktop to firefoxdeveloperedition.desktop

Loading...