FS#72284 - [lsb-release] [filesystem] Move lsb-release install changes to filesystem
Attached to Project:
Community Packages
Opened by Emil (xexaxo) - Wednesday, 29 September 2021, 12:32 GMT
Last edited by Jonas Witschel (diabonas) - Wednesday, 16 February 2022, 14:25 GMT
Opened by Emil (xexaxo) - Wednesday, 29 September 2021, 12:32 GMT
Last edited by Jonas Witschel (diabonas) - Wednesday, 16 February 2022, 14:25 GMT
|
Details
Description:
Currently, the install scriptlet of `lsb-release` changes the `/etc/arch-release` file. The file in itself is part of the `filesystem` package and is _not_ a backup file. As such, updating/reinstalling `filesystem` overwrites the file, discarding the `lsb-release` changes. IMHO the better solution is to provide a populated `/etc/arch-release` by filesystem package and with time - drop the lsb-release scriptlet. Although if maintainers prefer - one could add `/etc/arch-release` to the backup array in filesystem. Additional info: * package version(s) filesystem 2021.05.31-1 lsb-release 1.4-18 Steps to reproduce: - pacman -S filesystem lsb-release - install packages - observe the changes in /etc/arch-release, done by the latter - pacman -Qkk filesystem - rightfully complains that /etc/arch-release is modified - pacman -S filesystem - reinstall or update the package - the /etc/arch-release changes are lost |
This task depends upon
Closed by Jonas Witschel (diabonas)
Wednesday, 16 February 2022, 14:25 GMT
Reason for closing: Fixed
Additional comments about closing: 2.0.r48.3cf5103-1
Wednesday, 16 February 2022, 14:25 GMT
Reason for closing: Fixed
Additional comments about closing: 2.0.r48.3cf5103-1
From a quick look this has existed for 10+ year, since the initial import from AUR by @svenstaro - see https://github.com/archlinux/svntogit-community/commit/9f516458ec5f26a4c0d1ecbb5b86dd711965c16e#diff-8cd8de7d49033c97dfe2814415cdd9ea70853adefdcbefea7eeda3ea1b919d6b. Perhaps he has some insight why that wording should be used, if any.
Pretty sure you're all aware that many projects check for `/etc/arch-release` and fewer actually read it (os-prober comes to mind). Yet I have no idea how many of them actually care about the contents.
If people are happy with keeping `/etc/arch-release` empty - please go ahead. I'm high-lighting that as-is, things are unstable/unreproducible and IMHO should be fixed.
Happy to provide patches in any shape or form.