FS#72255 - [rocksdb] Build with Makefile instead of CMake

Attached to Project: Community Packages
Opened by Daan De Meyer (DaanDeMeyer) - Monday, 27 September 2021, 14:42 GMT
Last edited by Anatol Pomozov (anatolik) - Wednesday, 16 February 2022, 17:04 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Anatol Pomozov (anatolik)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

The generated CMake config files are unusable with CMake's find_package() if the static library is not installed (as is the case with this package). The call to find_package() will fail saying librocksdb.a can't be found. Instead, I'd recommend using rocksdb's Makefile which has separate targets for the shared library and the static library and also generates a pkg-config file. Installing the pkg-config file would also mimick Fedora so that users don't have to implement per-distro logic to use either the pkg-config file or the CMake config files depending on which one the distro installs. Standardizing on the pkg-config file seems like the better solution as pkg-config files are understood by more buildsystems than just CMake (and meson).

https://github.com/facebook/rocksdb/blob/main/INSTALL.md has more information on installing rocksdb's shared library.
This task depends upon

Closed by  Anatol Pomozov (anatolik)
Wednesday, 16 February 2022, 17:04 GMT
Reason for closing:  Fixed
Additional comments about closing:  rocksdb-6.23.3
Comment by Daan De Meyer (DaanDeMeyer) - Monday, 27 September 2021, 14:55 GMT
Additionally, the gflags dependency isn't required unless the rocksdb binaries are needed which isn't the case for this package so I think the gflags dependency can be removed as well.
Comment by Anatol Pomozov (anatolik) - Thursday, 30 September 2021, 03:37 GMT
rocksdb-6.23.3 has been pushed to testing repo. Please try and let me know if it works for you.

Loading...