FS#72176 - [tinyxml] CXXFLAGS should not be quoted and LDFLAGS should be added
Attached to Project:
Community Packages
Opened by Felix Yan (felixonmars) - Sunday, 19 September 2021, 22:18 GMT
Last edited by Alexander F. Rødseth (xyproto) - Monday, 20 September 2021, 11:01 GMT
Opened by Felix Yan (felixonmars) - Sunday, 19 September 2021, 22:18 GMT
Last edited by Alexander F. Rødseth (xyproto) - Monday, 20 September 2021, 11:01 GMT
|
Details
Description:
The current `g++ -fPIC "$CXXFLAGS" -shared -o "lib${pkgname}.so.0.$pkgver"` didn't pass CXXFLAGS well, as it should not be passed as a single argument. Also namcap suggests: ELF file ('usr/lib/libtinyxml.so.0.2.6.2') lacks FULL RELRO, check LDFLAGS. Which means LDFLAGS should be added here, too. Changing it like the following fixes both problems: - g++ -fPIC "$CXXFLAGS" -shared -o "lib${pkgname}.so.0.$pkgver" \ + g++ -fPIC $CXXFLAGS $LDFLAGS -shared -o "lib${pkgname}.so.0.$pkgver" \ Additional info: * package version(s) tinyxml 2.6.2-7 |
This task depends upon
Closed by Alexander F. Rødseth (xyproto)
Monday, 20 September 2021, 11:01 GMT
Reason for closing: Fixed
Monday, 20 September 2021, 11:01 GMT
Reason for closing: Fixed