Arch Linux

Description:
The `nvidia-utils` base package will fail to build when the path in which it is built contains `so`, and one of the shared libraries doesn't print a "Library soname" entry on `readelf -d`.

This occurs due to the sed regex using the wildcard character, `.`, instead of the escaped dot character, `\.`. Additionally, this issue only occurs when one of the shared libraries *doesn't* have a `Library soname` entry, so it makes sense that nobody had encountered this before me.

Here is `readelf -d` output on the shared library which produced this error for me: (useless stuff trimmed)

```
Dynamic section at offset 0x3e20 contains 24 entries:
Tag Type Name/Value
0x0000000000000001 (NEEDED) Shared library: [libEGL_nvidia.so.0]
0x0000000000000001 (NEEDED) Shared library: [libEGL.so.1]
0x0000000000000001 (NEEDED) Shared library: [libnvidia-egl-wayland.so.1]
0x0000000000000001 (NEEDED) Shared library: [libc.so.6]

[ other garbage ... ]
```

As you can see, there is no `Library soname: [...]` entry, as there should be.

This causes the `_base=$(echo ${_soname} | sed -r 's/(.*).so.*/\1.so/')` expression to be evaluated to, in my case, `/home.so` (as my username is `solonovamax`, so the path contains `/home/solonovamax/...`, and the fault sed regex matches `/home/so`, replacing it with `/home.so`.


This happened to me when building the AUR package `nvidia-dkms-performance`, so I took this opportunity to rewrite the `create_links()` function to be slightly more robust, so that it should avoid this, and possibly future, errors. I submitted a patch to that package, and they merged it and suggested I also submit a patch to the `nvidia-utils` package since that's where it was derived from, so here I am.

Here is a patch for the PKGBUILD:

```
--- PKGBUILD.old 2021-08-29 17:33:12.240556832 -0400
+++ PKGBUILD 2021-08-29 17:32:21.807128590 -0400
@@ -22,9 +22,25 @@
create_links() {
+ _orig_dir="$(pwd)"
+
# create soname links
find "$pkgdir" -type f -name '*.so*' ! -path '*xorg/*' -print0 | while read -d $'\0' _lib; do
- _soname=$(dirname "${_lib}")/$(readelf -d "${_lib}" | grep -Po 'SONAME.*: \[\K[^]]*' || true)
- _base=$(echo ${_soname} | sed -r 's/(.*).so.*/\1.so/')
- [[ -e "${_soname}" ]] || ln -s $(basename "${_lib}") "${_soname}"
- [[ -e "${_base}" ]] || ln -s $(basename "${_soname}") "${_base}"
+ _dirname="$(dirname "${_lib}")"
+ _original="$(basename "${_lib}")"
+ _soname="$(readelf -d "${_lib}" | grep -Po 'SONAME.*: \[\K[^]]*' || true)"
+ _base="$(echo ${_soname} | sed -r 's/(.*)\.so.*/\1.so/')"
+
+ cd "${_dirname}"
+
+ if ! [[ -z "${_soname}" ]]; then # if not empty
+ if ! [[ -e "./${_soname}" ]]; then
+ ln -s $(basename "${_lib}") "./${_soname}"
+ fi
+ fi
+ if ! [[ -z "${_base}" ]]; then # if not empty (if _soname is empty, _base should be too)
+ if ! [[ -e "./${_base}" ]]; then
+ ln -s "./${_soname}" "./${_base}"
+ fi
+ fi
done
+ cd "${_orig_dir}"
}
```