FS#71913 - noto-fonts-cjk fontconfig zh-hk serif pattern typo

Attached to Project: Arch Linux
Opened by T2hhbmEK (T2hhbmEK) - Tuesday, 24 August 2021, 17:56 GMT
Last edited by Antonio Rojas (arojas) - Tuesday, 31 August 2021, 12:49 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Antonio Rojas (arojas)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
Typo in 70-noto-cjk.conf i think.
"Noto Serif CJK HK" should be "Noto Serif CJK TC".

For "Noto Sans CJK", we have "Noto Sans CJK HK" and "Noto Sans CJK TC" for zh-hk and zh-tw.
However, for "Noto Serif CJK", we only have one Traditional Chinese font.
That font name is "Noto Serif CJK TC". There's no "Noto Serif CJK HK".
When it comes to serif, it should fallback to "zh-tw" for "zh-hk".
Pls use "Noto Serif CJK TC" for both "zh-hk" and "zh-tw" lang.

Additional info:
* package version(s): noto-fonts-cjk 20201206-2

Steps to reproduce:
* `$ LANG=zh_HK.UTF-8 fc-match sans` returns "Noto Sans CJK HK"
* `$ LANG=zh_HK.UTF-8 fc-match serif` returns the other font instead of "Noto Serif CJK HK"
This task depends upon

Closed by  Antonio Rojas (arojas)
Tuesday, 31 August 2021, 12:49 GMT
Reason for closing:  Fixed
Additional comments about closing:  noto-fonts-cjk 20201206-3
Comment by T2hhbmEK (T2hhbmEK) - Wednesday, 25 August 2021, 04:07 GMT
```xml
<match target="pattern">
<test name="lang">
<string>zh-hk</string>
</test>
<test name="family">
<string>serif</string>
</test>
<edit name="family" mode="prepend" binding="same">
<string>Noto Serif CJK TC</string>
</edit>
</match>
```
Just found that it won't work without setting binding to "same" or "strong".
Can't explain why. It works well for zh-tw/zh-cn without same/strong binding.
Comment by T2hhbmEK (T2hhbmEK) - Wednesday, 25 August 2021, 04:22 GMT
Found that in aur/noto-fonts-cjk-hk-vf, they just removed the setting for zh-hk serif.
It might behaves the same with setting "Noto Serif CJK HK".
Comment by T2hhbmEK (T2hhbmEK) - Wednesday, 25 August 2021, 04:49 GMT
Did some digging, found Ubuntu package using strong binding for zh-cn/zh-tw/zh-hk.
For ja & ko, they omit the binding option.
However, they did not change "Noto Serif CJK HK" to "Noto Serif CJK TC".
Comment by Antonio Rojas (arojas) - Monday, 30 August 2021, 19:52 GMT
Can you please provide a fixed conf file?
Comment by T2hhbmEK (T2hhbmEK) - Tuesday, 31 August 2021, 00:11 GMT
fixed conf with strong binding for zh-*
   70-noto-cjk.conf (4.8 KiB)
Comment by Antonio Rojas (arojas) - Tuesday, 31 August 2021, 12:48 GMT
Thanks!

Loading...