FS#71832 - [gpm] gpm.sh should be installed as non-executable
Attached to Project:
Arch Linux
Opened by Emanuele Torre (emanuele6) - Saturday, 14 August 2021, 02:30 GMT
Last edited by Christian Hesse (eworm) - Tuesday, 31 August 2021, 19:07 GMT
Opened by Emanuele Torre (emanuele6) - Saturday, 14 August 2021, 02:30 GMT
Last edited by Christian Hesse (eworm) - Tuesday, 31 August 2021, 19:07 GMT
|
Details
Description:
Hello. /etc/profile.d/ files do not need to be installed as executable since they are sourced (i.e. read) from /etc/profile and not executed. It does not even make much sense to execute /etc/profile.d/ scripts since they only set variables in their own environment and then do nothing else. It would be nice if core/gpm did not install gpm.sh as executable. core/gawk, core/perl and many other packages use 644 which I also think is the best set of permissions for /etc/profile.d/ files. To solve this, you simply need to change this line of the PKGBUILD file from: install -D -m0755 ../gpm.sh "${pkgdir}/etc/profile.d/gpm.sh" to: install -D -m0644 ../gpm.sh "${pkgdir}/etc/profile.d/gpm.sh" Cheers, emanuele6 Additional info: * package version of core/gpm: 1.20.7.r38.ge82d1a6-3 Steps to reproduce: $ stat /etc/profile.d/gpm.sh |
This task depends upon
Closed by Christian Hesse (eworm)
Tuesday, 31 August 2021, 19:07 GMT
Reason for closing: Fixed
Additional comments about closing: gpm 1.20.7.r38.ge82d1a6-4
Tuesday, 31 August 2021, 19:07 GMT
Reason for closing: Fixed
Additional comments about closing: gpm 1.20.7.r38.ge82d1a6-4