FS#71689 - [archiso][e2fsprogs] profile using ext4+squashfs fails on e2fsprogs 1.46.3

Attached to Project: Release Engineering
Opened by mark (qinohe) - Sunday, 01 August 2021, 23:35 GMT
Last edited by Christian Hesse (eworm) - Tuesday, 03 August 2021, 15:18 GMT
Task Type Bug Report
Category ArchISO
Status Closed
Assigned To Christian Hesse (eworm)
David Runge (dvzrv)
Architecture x86_64
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Hi archiso team, using 'erofs' or 'ext4+squashfs' fails with default mkarchiso.

In mkarchiso needed to change the following to get working ISO's with above options set.

In _mkairootfs_ext4+squashfs function change to:
#mkfs.ext4 -O '^has_journal,^resize_inode' -E 'lazy_itable_init=0' -m 0 -F "${pacstrap_dir}.img" 32G
fallocate -l 32G "${pacstrap_dir}.img"
mkfs.ext4 -O '^has_journal,^resize_inode' -E 'lazy_itable_init=0' -m 0 -F "${pacstrap_dir}.img"

In _mkairootfs_erofs function:
#mkfs.erofs -U "${fsuuid}" "${airootfs_image_tool_options[@]}" -- "${image_path}" "${pacstrap_dir}"
mkfs.erofs -U "${fsuuid}" -- "${image_path}" "${pacstrap_dir}"

see this thread: https://bbs.archlinux.org/viewtopic.php?id=268477

Regards, Mark
This task depends upon

Closed by  Christian Hesse (eworm)
Tuesday, 03 August 2021, 15:18 GMT
Reason for closing:  Fixed
Additional comments about closing:  e2fsprogs 1.46.3-3
Comment by nl6720 (nl6720) - Monday, 02 August 2021, 05:06 GMT
erofs works just fine. When using it, airootfs_image_tool_options in profiledef.sh needs to use mkfs.erofs options instead of those for mksquashfs. See https://gitlab.archlinux.org/archlinux/archiso/-/blob/master/docs/README.profile.rst
Comment by David Runge (dvzrv) - Monday, 02 August 2021, 07:21 GMT
@qinohe: Thanks for the report.

As pointed out by @nl6720, the profile that is being built must be configured accordingly, as the `airootfs_image_tool_options` may refer to squashfs or erofs.
Comment by David Runge (dvzrv) - Monday, 02 August 2021, 07:35 GMT
Sorry, too early to read for me apparently... -_-

The ext4+squashfs issue is what actually matters in this ticket (as the erofs related issue is a configuration problem).

I'll add eworm to this ticket, so that we may track any progress on e2fsprogs, as the 1.46.3 release apparently causes the problem here.
Comment by Christian Hesse (eworm) - Monday, 02 August 2021, 11:44 GMT
This is the offending commit:
https://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git/commit/?id=942b00cb9d2f2b52f4c58877d523145ee59a89b0
Comment by Christian Hesse (eworm) - Monday, 02 August 2021, 12:03 GMT
Reverted in e2fsprogs 1.46.3-2
Comment by mark (qinohe) - Monday, 02 August 2021, 14:10 GMT
@nl6720 @David, it was the first time I used anything else then 'squashfs' and completely missed I need to set 'airootfs_image_tool_options' too, sorry about that and thanks for pointing that out.
So, it's clear options don't need to be set(empty) for erofs to get a working ISO ;-)

@Cristian, thanks for releasing e2fsprogs 1.46.3-2.

edit: the patch works fine, thanks.
Comment by Christian Hesse (eworm) - Tuesday, 03 August 2021, 15:18 GMT
Final upstream fix in e2fsprogs 1.46.3-3

Loading...