FS#71547 - [mtool]s regression, mcopy fails with no directory slots

Attached to Project: Arch Linux
Opened by Maciek Borzecki (bboozzoo) - Monday, 19 July 2021, 11:45 GMT
Last edited by David Runge (dvzrv) - Friday, 15 October 2021, 07:46 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To David Runge (dvzrv)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 3
Private No

Details

Description:

A regression from mtools 4.0.32. mcopy can no longer copy the content to the image.

Additional info:
* mtools 1:4.0.33-1

Steps to reproduce:

dd if=/dev/zero of=img bs=1M count=512
mkfs.vfat -F 32 img
# have a tree with some directories and files inside
$ du -sch work/image-home/root/
371M work/image-home/root/
371M total
mcopy -s -i img work/image-home/root/EFI ::

Produces:

mcopy: No directory slots
mcopy: No directory slots
This task depends upon

Closed by  David Runge (dvzrv)
Friday, 15 October 2021, 07:46 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed with 4.0.34
Comment by David Runge (dvzrv) - Thursday, 22 July 2021, 07:15 GMT
@bbozzoo: Thanks for the report.

However, I believe this is a user error (not a packaging bug). You did not create the directories before trying to copy to them.
Have a look at how we do that in archiso [1].

If still you think you have hit a bug in mtools, please contact the maintainer of mtools and report it: https://lists.gnu.org/mailman/listinfo/info-mtools

[1] https://gitlab.archlinux.org/archlinux/archiso/-/blob/c88fe823b670663cd3c5ee1d33c3f921822e2887/archiso/mkarchiso#L539-543
Comment by Maciek Borzecki (bboozzoo) - Thursday, 14 October 2021, 22:00 GMT
  • Field changed: Percent Complete (100% → 0%)
Perhaps that wasn't clearly stated in the bug report. It worked with earlier versions of mtools. Notice that -s was passed in the command line, which implies recursive directory copy. In that sense, updating to mtools 4.0.33 breaks existing tools and is a regression, is it not?
Comment by David Runge (dvzrv) - Friday, 15 October 2021, 07:34 GMT
@bboozzoo: Is this still an issue with 4.0.35 and have you contacted upstream about this?
Comment by Maciek Borzecki (bboozzoo) - Friday, 15 October 2021, 07:38 GMT
@dvzrv I've contacted the upstream on July 23 2021, and it was fixed the same day in 4.0.34 release. I can confirm that the current release 4.0.35 still works correctly, so the task can be closed.
Comment by David Runge (dvzrv) - Friday, 15 October 2021, 07:42 GMT
Please note, that mcopy's `-s` [1] does not imply the creation of the *target* directory structure, but only: "Recursive copy. Also copies directories and their contents"

The behavior you were relying upon might have been seen as a bug upstream and thus the behavior changed.
To find that out for sure, you'd have to ask the maintainer about this though as there is no way of - painlessly - telling without a publicly accessible source repository (or fixing anything for that matter).

Closing: This is not a packaging issue but an upstream issue.

[1] https://man.archlinux.org/man/mcopy.1#Description
Comment by David Runge (dvzrv) - Friday, 15 October 2021, 07:46 GMT
@bboozzoo: My bad. It appears that flyspray set a current timestamp for your comment upon reopening this ticket. I assume that https://bugs.archlinux.org/task/71547#comment202940 was actually from back then.

Glad it works now and sorry for going all explainy here...

Loading...