FS#71542 - tdesktop and tg_owt shouldn't have *_SPECIAL_TARGET variables set
Attached to Project:
Community Packages
Opened by Ilya Fedin (ilya-fedin) - Sunday, 18 July 2021, 18:06 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Wednesday, 04 August 2021, 22:23 GMT
Opened by Ilya Fedin (ilya-fedin) - Sunday, 18 July 2021, 18:06 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Wednesday, 04 August 2021, 22:23 GMT
|
Details
Description:
*_SPECIAL_TARGET variables in tdesktop and related packages mean that official build mode should be turned on, leading to using hardcoded paths instead of using pkg-config/find_package, what also leads to the lack of dependencies in tg_owtConfig.cmake. All what should be set in tg_owt is: ``` cmake -G Ninja \ -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_INSTALL_PREFIX=/usr \ .. ``` (and maybe `-DBUILD_SHARED_LIBS=OFF` if you want to build a static lib) For tdesktop: ``` cmake . \ -B build \ -G Ninja \ -DCMAKE_INSTALL_PREFIX="/usr" \ -DCMAKE_BUILD_TYPE=Release \ -DTDESKTOP_API_ID=611335 \ -DTDESKTOP_API_HASH=d524b414d21f4d37f08684c1df41ac9c ``` |
This task depends upon
Closed by Sven-Hendrik Haase (Svenstaro)
Wednesday, 04 August 2021, 22:23 GMT
Reason for closing: Fixed
Wednesday, 04 August 2021, 22:23 GMT
Reason for closing: Fixed
btw, you can move gtk3 and webkit2gtk to optional dependencies since they're used with dlopen now, again.. You may also want to add xdg-desktop-portal to optional dependencies since tdesktop heavily uses portal API, e.g. for system dialogs (file dialog, open with dialog), for getting DE settings like dark mode.
By the way, I don't think tg_owt not having a stable ABI is a problem since we'll rebuild telegram-desktop with every one of it's updates anyway.
webkit2gtk is used only for bot payments right now AFAIK and doesn't have any fallback (it will show a dialog that asks to install it). Although, they may use it for more features that require embedded browser in the future (like instant view).
xdg-desktop-portal/gtk3 aren't so important (at least in my view) to be in fixed deps. People who don't use gtk-based DEs won't benefit from reading gtk settings if they don't have it for anything else (so, not configured). And xdg-desktop-portal has only two full-feature backends AFAIK (gtk/kde).
There are some packages in AUR that depend on it, but if you don't care, then ¯\_(ツ)_/¯