FS#71526 - [kodi] No Wayland support in Kodi 19.1-5

Attached to Project: Community Packages
Opened by Bálint (balint355) - Friday, 16 July 2021, 17:32 GMT
Last edited by Ike Devolder (BlackEagle) - Sunday, 01 August 2021, 09:35 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Ike Devolder (BlackEagle)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 6
Private No

Details

Description:

The latest version is supposed to support multiple windowing systems like X and Wayland in a single binary, but there seems to be no Wayland support in the binary of the latest package version. According to the upstream merge request [1] that added this feature, running kodi --help should list all the available windowing systems, and it only reports x11 for me:

$ kodi --help
[...]
--windowing=<system> Select which windowing method to use.
Available window systems are: x11

Additional info:

I'm running GNOME on Wayland.

Steps to reproduce:

1. Run kodi --help
2. Check available window systems

[1] https://github.com/xbmc/xbmc/pull/18534
This task depends upon

Closed by  Ike Devolder (BlackEagle)
Sunday, 01 August 2021, 09:35 GMT
Reason for closing:  Fixed
Additional comments about closing:  kodi 19.1-6
Comment by John (graysky) - Friday, 16 July 2021, 20:01 GMT
I believe gbm is also missing. There is only usr/lib/kodi/kodi-x11 but I think it should be building kodi.bin if I am not mistaken.

EDIT: One or more of the new cmake args is breaking this. If I just add a few needed for video accel playback, kodi.bin builds as expected. See: https://aur.archlinux.org/cgit/aur.git/commit/?h=kodi-matrix-git&id=c1c785227c0fd9f3d2a8136487f04ef01873432e
Comment by Bálint (balint355) - Saturday, 17 July 2021, 10:48 GMT
The latest version of the kodi-matrix-git AUR package produces the correct binaries with all three window systems supported. However, changing the cmake arguments in the PKGBUILD of kodi in community to similar values as in the AUR package, it still only builds a binary with one window system. It seems to only build for whatever comes first in -DCORE_PLATFORM_NAME, eg. if I write wayland first, it builds a Wayland-only binary.
Comment by loqs (loqs) - Saturday, 17 July 2021, 12:37 GMT
See attached diff.
Comment by Bálint (balint355) - Saturday, 17 July 2021, 13:09 GMT
The diff fixes the issue, thanks! Another way to fix this then, is to enclose ${_cmake_common_args[@]} with "" when invoking cmake, as in attached diff - the kodi-matrix-git package also does this.
Comment by John (graysky) - Saturday, 17 July 2021, 13:11 GMT
The default is to build all three so we can just omit the -DCORE_PLATFORM_NAME arg all together.
Comment by Arseny Vakhrushev (waxar) - Saturday, 31 July 2021, 00:20 GMT
GBM support is broken too.😢
What would be the best workaround for the time being? Switch to AUR kodi-matrix-git?
Comment by Bálint (balint355) - Saturday, 31 July 2021, 18:57 GMT
Yes, the kodi-matrix-git package properly supports GBM and Wayland, so that's a good workaround for now. You could also build the kodi package with one of the diffs from the comments here applied to the original PKGBUILD.

Loading...