FS#71437 - [python-django-q] Missing dependency (python-redis)

Attached to Project: Community Packages
Opened by Kristian (klausenbusk) - Sunday, 04 July 2021, 13:02 GMT
Last edited by Maxime Gauduin (Alucryd) - Wednesday, 28 July 2021, 12:25 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To David Runge (dvzrv)
Maxime Gauduin (Alucryd)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: When packaging mailman-web[1] I noticed a missing dependency.

Running the mailman-web command it fails with:
pkg_resources.DistributionNotFound: The 'redis<4.0.0,>=3.5.3' distribution was not found and is required by django-q
Checking the METADATA file redis is indeed required and not optional as documented[2][3]
$ grep -E 'redis|boto' /usr/lib/python3.9/site-packages/django_q-1.3.9.dist-info/METADATA
Requires-Dist: boto3 (>=1.14.12,<2.0.0); extra == "testing"
Requires-Dist: django-redis (>=4.12.1,<5.0.0); extra == "testing"
Requires-Dist: hiredis (>=1.0.1,<2.0.0); extra == "testing"
Requires-Dist: redis (>=3.5.3,<4.0.0)

^ See the missing extra == "blabla"

[1] https://gitlab.com/mailman/mailman-web/
[2] https://github.com/Koed00/django-q/blob/685691ff4c8ec8d7a683228f9a320881eccf1404/docs/install.rst#optional
[3] https://github.com/Koed00/django-q/blob/85baaccd2c3adfe0a414d4237465163e9ff6e5a0/pyproject.toml#L51

Additional info:
* python-django-q 1.3.9-1
This task depends upon

Closed by  Maxime Gauduin (Alucryd)
Wednesday, 28 July 2021, 12:25 GMT
Reason for closing:  Fixed
Additional comments about closing:  added it in depends, thanks!
Comment by David Runge (dvzrv) - Tuesday, 06 July 2021, 09:17 GMT
@klausenbusk: Thanks for the report!

It seems that python-redis is indeed a hard requirement for python-django-q (despite what the pyproject.toml says).
I've tried to build using setuptools by converting the pyproject.toml to a setup.py (using dephell), but apart from additional __pycache__ stuff the hard requirement on python-redis remains.

Loading...