FS#71373 - [mpv] overlinking with waf

Attached to Project: Community Packages
Opened by loqs (loqs) - Sunday, 27 June 2021, 13:55 GMT
Last edited by Toolybird (Toolybird) - Thursday, 20 April 2023, 03:34 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Christian Hesse (eworm)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
waf places LDFLAGS at the end of the link command, --as-needed need to come before libraries in order to prevent overlinking.
waf has a second variable LINKFLAGS which is placed much earlier in the link command and allows --as-needed to work as intended.
[1] exports LINKFLAGS in build() set to the value of LDFLAGS.

Additional info:
* mpv 1:0.33.1-2
[1] PKGBUILD.diff

Steps to reproduce:
namcap mpv-1\:0.33.1-2-x86_64.pkg.tar.zst
...
mpv W: Unused shared library '/usr/lib/libdvdread.so.8' by file ('usr/bin/mpv')
mpv W: Unused shared library '/usr/lib/librt.so.1' by file ('usr/bin/mpv')
mpv W: Unused shared library '/usr/lib/libfftw3.so.3' by file ('usr/bin/mpv')
mpv W: Unused shared library '/usr/lib/libsamplerate.so.0' by file ('usr/bin/mpv')
mpv W: Unused shared library '/usr/lib/libdvdread.so.8' by file ('usr/lib/libmpv.so.1.109.0')
mpv W: Unused shared library '/usr/lib/librt.so.1' by file ('usr/lib/libmpv.so.1.109.0')
mpv W: Unused shared library '/usr/lib/libfftw3.so.3' by file ('usr/lib/libmpv.so.1.109.0')
mpv W: Unused shared library '/usr/lib/libsamplerate.so.0' by file ('usr/lib/libmpv.so.1.109.0')
...
   PKGBUILD.diff (0.2 KiB)
This task depends upon

Closed by  Toolybird (Toolybird)
Thursday, 20 April 2023, 03:34 GMT
Reason for closing:  Fixed
Additional comments about closing:  mpv 1:0.35.0-5 switched to meson build and removed waf from makedeps.

Loading...