Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#71316 - [ppp] systemd support

Attached to Project: Arch Linux
Opened by Max Resch (mxr) - Sunday, 20 June 2021, 14:23 GMT
Last edited by Felix Yan (felixonmars) - Monday, 11 September 2023, 21:07 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Felix Yan (felixonmars)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 3
Private No

Details

Consider Building ppp with SYSTEMD=y set in ppp/Makefile.linux this enables the up_sdnotify flag in pppd configuration which in turn allows writing a systemd.service file like this:

[Service]
Type=notify
ExecStart=/usr/bin/pppd call %I up_sdnotify nolog
ExecReload=/bin/kill -HUP $MAINPID
SuccessExitStatus=5


which has the same effect as using type forking; it stays in state "activating" until a connection could be established. Setting SYSTEMD=y and not using up_sdnotify does not modify pppd's behavior and should have no impact an existing configs. Introduces a runtime dependency on systemd-libs which is in core and should be installed on all archlinux installations.


Furthermore in looking at the ppp PKGCONFIG I noticed that setting FILTER=y and HAVE_INET6=y is unnecessary, ppp's default already does that. Setting CFLAGS before ./configure has no effect ./configure overrides CFLAGS use --cflags="$CPPFLAGS $CFLAGS" as a parameter to ./configure; also -D_GNU_SOURCE does not seem to required any more.
This task depends upon

Closed by  Felix Yan (felixonmars)
Monday, 11 September 2023, 21:07 GMT
Reason for closing:  Implemented
Additional comments about closing:  2.5.0
Comment by Marcell Meszaros (MarsSeed) - Thursday, 06 July 2023, 09:10 GMT
Implementing this change would be useful.
Comment by Buggy McBugFace (bugbot) - Tuesday, 08 August 2023, 19:11 GMT
This is an automated comment as this bug is open for more then 2 years. Please reply if you still experience this bug otherwise this issue will be closed after 1 month.
Comment by Max Resch (mxr) - Monday, 11 September 2023, 20:52 GMT
seems to be integrated into 2.5.0, so close

Loading...