FS#71156 - [obs-studio] PKGBUILD improvements

Attached to Project: Community Packages
Opened by Trystan Mata (tytan652) - Monday, 07 June 2021, 11:10 GMT
Last edited by Jonathan Steel (jsteel) - Tuesday, 08 June 2021, 08:17 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Jonathan Steel (jsteel)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

- The optional dependency and make dependency to "vlc" is still despite the added "DISABLE_VLC" flag.

- "libxcomposite" and "pipewire" are both needed for "linux-capture" but it's explicitly said or put as non-optional dependencies

- The "BUILD_CAPTIONS" flag does not exist anymore

- "qt5-x11extras" is no longer needed since OBS 27
This task depends upon

Closed by  Jonathan Steel (jsteel)
Tuesday, 08 June 2021, 08:17 GMT
Reason for closing:  Implemented
Additional comments about closing:  27.0.0-2
Comment by Trystan Mata (tytan652) - Monday, 07 June 2021, 11:11 GMT
Yikes, I forgot to change the severity to a higher level.

Mistake, i forgot the "not" before the "explicitly".

Sorry
Comment by Jonathan Steel (jsteel) - Monday, 07 June 2021, 16:14 GMT
Thanks for the suggestions, yes I totally missed removing the vlc dependencies. I don't think the severity is any higher than low, as the worst harm here is pulling in some unnecessary dependencies that will soon be corrected. I've staged the changes for the next version bump but if that doesn't happen in the next week or so I'll push a new release.
Comment by Denis Schultz (tiberiumschniffer) - Tuesday, 08 June 2021, 07:04 GMT
"as the worst harm here is pulling in some unnecessary dependencies that will soon be corrected."

I have to politely disagree.

- "libxcomposite" and "pipewire" are both needed for "linux-capture" but it's not explicitly said or put as non-optional dependencies

This is a hard break. OBS user who updated to the latest version, can not record they screen anymore. There is a unusually high count on support request in discord, because of missing one or both packages.

Comment by Trystan Mata (tytan652) - Tuesday, 08 June 2021, 07:31 GMT
Not only their discord but their Github repo also receive issues because users of this package can't use linux-capture "anymore".

https://github.com/obsproject/obs-studio/issues/4823
https://github.com/obsproject/obs-studio/issues/4836
https://github.com/obsproject/obs-studio/issues/4839
Comment by Jonathan Steel (jsteel) - Tuesday, 08 June 2021, 07:56 GMT
I think optional dependencies here is totally valid, and users not reviewing optional dependencies isn't really and issue, but there are two good points here; optional dependencies are not descriptive here, and actually you can argue this is an essential feature that should not be optional. So agreed, I'll add them to non-optional dependencies.

Loading...